Re: Xen panics in autoconf

[Martin Husemann <martin%duskware.de@localhost>]

On Tue, Jun 15, 2021 at 09:17:17AM +0200, Manuel Bouyer wrote:
> Hello,
> some recent changes broke Xen:
> [   2.0000919] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file "/usr/src/sys/kern/subr_autoconf.c", line 1039 
> [   2.0000919] cpu0: Begin traceback...
> [   2.0000919] vpanic(c05be3c0,cd02ddb8,cd02ddd4,c0415210,c05be3c0,c05be322,c05c6cc1,c05f4284,40f,cd02de18) at netbsd:vpanic+0x139
> [   2.0000919] kern_assert(c05be3c0,c05be322,c05c6cc1,c05f4284,40f,cd02de18,c0b84b60,0,cd02ddf4,c0415270) at netbsd:kern_assert+0x23
> [   2.0000919] config_match(c12e6c00,c0b84b60,cd02ded8,c0b84b60,c0b84b60,c12e6c00,cd02de3c,c04155d2,cd02de18,c0428627) at netbsd:config_match+0x90
> [   2.0100679] mapply(cd02de18,c0428627,0,c12e5dc0,ffffffff,c0cb6524,cd02de18,0,c12e6c00,0) at netbsd:mapply+0x50
> [   2.0100679] config_vsearch(c12e6c00,cd02ded8,eeeeeeee,cd02dea0,cd02de88,c01120af,0,c1460278,cd02dee6,c05c06cd) at netbsd:config_vsearch+0x212
> [   2.0100679] config_vfound(c12e6c00,cd02ded8,c0111f20,eeeeeeee,cd02dea0,cd02df00,c0112638,c12e6c00,cd02ded8,c0111f20) at netbsd:config_vfound+0x2f
> [   2.0100679] config_found(c12e6c00,cd02ded8,c0111f20,eeeeeeee,a,8,0,c12ddf54,0,c12c21f0) at netbsd:config_found+0x2d
> [   2.0100679] xenbus_probe_device_type(cd02df2e,1e,c05c0734,c12ddf54,cd02df24,4,c12ddf44,c12ddf44,2,65640000) at netbsd:xenbus_probe_device_type+0x498
> [   2.0100679] xenbus_probe_frontends.isra.0(60,2,0,c0113430,0,c05bec62,0,0,cd02df9c,c0112e65) at netbsd:xenbus_probe_frontends.isra.0+0xbb
> [   2.0100679] xenbus_probe(0,c05c076d,6,c1453c00,0,c0102031,c1453c00,d99000,c0b92200,0) at netbsd:xenbus_probe+0x2d
> [   2.0100679] xenbus_probe_init(c1453c00,d99000,c0b92200,0,c0100084,0,0,0,0,0) at netbsd:xenbus_probe_init+0x85
> [   2.0100679] cpu0: End traceback...
> 
> Any idea what changed recently ?

The KASSERT was added :-)

xenbus_probe_init should hold the kernel lock?

Martin