Re: Automated report: NetBSD-current/i386 build failure

[christos%astron.com@localhost (Christos Zoulas)]

In article <s8o8ot$929$1%ciao.gmane.io@localhost>,
Christos Zoulas <christos%astron.com@localhost> wrote:
>In article <24751.41935.824926.178259%guava.gson.org@localhost>,
>Andreas Gustafsson  <gson%gson.org@localhost> wrote:
>>The i386 build is still failing, but now with a different error:
>>
>>  --- in6_pcb.o ---
>>  /tmp/build/2021.05.27.08.58.29-i386/src/sys/netinet6/in6_pcb.c: In
>>function 'in6_pcblookup_port':
>>  cc1: error: function may return address of local variable
>>[-Werror=return-local-addr]
>> 
>>/tmp/build/2021.05.27.08.58.29-i386/src/sys/netinet6/in6_pcb.c:1056:26:
>>note: declared here
>>   1056 |   struct vestigial_inpcb better;
>>        |                          ^~~~~~
>>
>>It's not clear to me which of the commits made since christos first
>>broke the build could have triggered this, nor why this is not
>>affecting all ports.
>
>That code is tricky and the compiler usage analysis might not be figuring
>out that this can't happen. When I last looked at it, I considered simplifying
>it so that it is obvious that this can't happen.

I think that did it :-)

Modified Files:
        src/external/gpl3/gcc: README.gcc10
        src/share/mk: bsd.own.mk

Log Message:
switch mips* and i386 to GCC 10.

I guess I'll have to simplify it for real now :-)

christos