Yes, I think that the appropriate change is to make those assertions so if there is a broken filesystem/syscall there is a more obvious error (rather than infinite loop in read or core-dump in iconv), but let's see what joerg thinks about all that. Best, christos > On Apr 2, 2021, at 5:13 PM, RVP <rvp%SDF.ORG@localhost> wrote: > > On Fri, 2 Apr 2021, Christos Zoulas wrote: > >>> f_iosize is also overridden (512 vs. 4k from FUSE-ext2). >> >> I think all that initialization is done here: >> https://nxr.netbsd.org/xref/src/lib/libpuffs/subr.c#102 >> and here: >> https://nxr.netbsd.org/xref/src/sys/fs/puffs/puffs_vfsops.c#211 >> > > Yes, I noticed those. > >> I am not sure if the puffs stavfs values are supposed to reflect the >> values of the underlying filesystem or they are supposed to be standard >> values for puffs filesystems (which seems to be the case). >> > > OK. > >> I believe I have fixed that. >> > > Excellent! Where, though? Will you then be changing the libarchive fixes > to something else? asserts or error-returns from > setup_current_filesystem() maybe? > > -RVP
Attachment:
signature.asc
Description: Message signed with OpenPGP