Re: PATCH: Relax fdatasync checks to IEEE Std 1003.1-2008

[Paul Ripke <stix%stix.id.au@localhost>]

On Thu, Mar 12, 2020 at 09:49:34AM -0400, Greg Troxel wrote:
> Paul Ripke <stix%stix.id.au@localhost> writes:
> 
> > Currently, fdatasync requires a file descriptor open for writing, as
> > per IEEE Std 1003.1, 2004:
> > [EBADF]
> > The fildes argument is not a valid file descriptor open for writing.
> > https://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html
> >
> > While, IEEE Std 1003.1-2008 (and later revisions):
> > [EBADF]
> > The fildes argument is not a valid file descriptor.
> > https://pubs.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html
> 
> I didn't realize that there was a change in POSIX.  That makes things
> quite different.

Indeed.

> It would help if someone ran the entire atf test suite; you might
> install py-anita to do so.

Running atf on a GCP VM. Never run atf before, we'll see how it goes.

> I am inclined to commit this change if there aren't objections.

-- 
Paul Ripke
"Great minds discuss ideas, average minds discuss events, small minds
 discuss people."
-- Disputed: Often attributed to Eleanor Roosevelt. 1948.