Re: New ATF test failures

[Paul Goyette <paul%whooppee.com@localhost>]

Working on it.  As far as I can tell, it just needs to initialize the
newly-created module_hook synchronization variables.

I'll commit the fix as soon as I can test it.


Index: rump.c
===================================================================
RCS file: /cvsroot/src/sys/rump/librump/rumpkern/rump.c,v
retrieving revision 1.337
diff -u -p -r1.337 rump.c
--- rump.c      7 Dec 2019 14:55:58 -0000       1.337
+++ rump.c      15 Dec 2019 13:43:06 -0000
@@ -52,6 +52,7 @@ __KERNEL_RCSID(0, "$NetBSD: rump.c,v 1.3
 #include <sys/ksyms.h>
 #include <sys/msgbuf.h>
 #include <sys/module.h>
+#include <sys/module_hook.h>
 #include <sys/namei.h>
 #include <sys/once.h>
 #include <sys/percpu.h>
@@ -412,6 +413,7 @@ rump_init(void)
 	iostat_init();
 	fd_sys_init();
 	module_init();
+	module_hook_init();
 	devsw_init();
 	pipe_init();
 	resource_init();




On Sun, 15 Dec 2019, Andreas Gustafsson wrote:

> The following test cases are now failing on multiple testbeds:
>
>  dev/sysmon/t_swsensor/alarm_sensor
>  dev/sysmon/t_swsensor/entropy_interrupt_sensor
>  dev/sysmon/t_swsensor/entropy_polled_sensor
>  dev/sysmon/t_swsensor/limit_sensor
>  dev/sysmon/t_swsensor/simple_sensor
>  net/if_vlan/t_vlan/vlan_auto_follow_mtu
>  net/if_vlan/t_vlan/vlan_auto_follow_mtu6
>  net/if_vlan/t_vlan/vlan_basic
>  net/if_vlan/t_vlan/vlan_basic6
>  net/if_vlan/t_vlan/vlan_bridge
>  net/if_vlan/t_vlan/vlan_bridge6
>  net/if_vlan/t_vlan/vlan_configs
>  net/if_vlan/t_vlan/vlan_configs6
>  net/if_vlan/t_vlan/vlan_create_destroy
>  net/if_vlan/t_vlan/vlan_create_destroy6
>  net/if_vlan/t_vlan/vlan_multicast
>  net/if_vlan/t_vlan/vlan_multicast6
>  net/if_vlan/t_vlan/vlan_vlanid
>  net/if_vlan/t_vlan/vlan_vlanid6
>
> since these commits:
>
>  2019.12.12.22.55.20 pgoyette src/sys/kern/files.kern 1.39
>  2019.12.12.22.55.20 pgoyette src/sys/kern/init_main.c 1.509
>  2019.12.12.22.55.20 pgoyette src/sys/kern/kern_module.c 1.141
>  2019.12.12.22.55.20 pgoyette src/sys/kern/kern_module_hook.c 1.1
>  2019.12.12.22.55.20 pgoyette src/sys/rump/librump/rumpkern/Makefile.rumpkern 1.178
>  2019.12.12.22.55.20 pgoyette src/sys/sys/module_hook.h 1.6
>  2019.12.12.22.55.20 pgoyette src/sys/sys/param.h 1.624
>
> For logs, see:
>
>  http://www.gson.org/netbsd/bugs/build/amd64-baremetal/commits-2019.12.html#2019.12.12.22.55.20
>
> --
> Andreas Gustafsson, gson%gson.org@localhost
>
> !DSPAM:5df6011f137371101510858!

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+