Re: i386 9.99.17 build fails for NET4501 kernel

[Lars Reichardt <lars%paradoxon.info@localhost>]

On Mon, 14 Oct 2019 10:31:08 +0100
Patrick Welche <prlw1%cam.ac.uk@localhost> wrote:

> On Sun, Oct 13, 2019 at 04:31:08PM -0500, John D. Baker wrote:
> > Building the NET4501 kernel with 9.99.17 sources fails with:
> > 
> > [...]
> > #   compile  NET4501/vm_machdep.o
> > /r0/build/current/tools/amd64/bin/i486--netbsdelf-gcc -msoft-float
> > -mno-mmx -mno-sse -mno-avx -ffreestanding
> > -fno-zero-initialized-in-bss -fno-delete-null-pointer-checks -g -Os
> > -fstack-protector -Wstack-protector --param ssp-buffer-size=1
> > -fno-strict-aliasing -fno-common -std=gnu99 -Werror -Wall -Wno-main
> > -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
> > -Wstrict-prototypes -Wold-style-definition -Wswitch -Wshadow
> > -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign
> > -Wno-attributes -Wextra -Wno-unused-parameter
> > -Wold-style-definition -Wno-sign-compare
> > --sysroot=/r0/build/current/DEST/i386 -Di386 -I.
> > -I/x/current/src/sys/external/bsd/acpica/dist
> > -I/x/current/src/sys/external/bsd/libnv/dist
> > -I/x/current/src/sys/../common/lib/libx86emu
> > -I/x/current/src/sys/../common/lib/libc/misc
> > -I/x/current/src/sys/../common/include -I/x/current/src/sys/arch
> > -I/x/current/src/sys -nostdinc -DCOMPAT_UTILS -DTIMER_FREQ=1189200
> > -DCOMPAT_44 -D_KERNEL -D_KERNEL_OPT -std=gnu99
> > -I/x/current/src/sys/lib/libkern/../../../common/lib/libc/quad
> > -I/x/current/src/sys/lib/libkern/../../../common/lib/libc/string
> > -I/x/current/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
> > -D_FORTIFY_SOURCE=2
> > -I/x/current/src/sys/external/isc/atheros_hal/dist
> > -I/x/current/src/sys/external/isc/atheros_hal/ic
> > -I/x/current/src/sys/external/bsd/libnv/dist -c
> > /x/current/src/sys/arch/x86/x86/vm_machdep.c -o vm_machdep.o
> > /x/current/src/sys/arch/x86/x86/vm_machdep.c: In function
> > 'cpu_lwp_fork':
> > /x/current/src/sys/arch/x86/x86/vm_machdep.c:134:21: error:
> > variable 'pcb2' might be clobbered by 'longjmp' or 'vfork'
> > [-Werror=clobbered] struct pcb *pcb1, *pcb2;  
> 
> I can reproduce this on amd64 with:
> 
> include "arch/amd64/conf/GENERIC"
> no options      DIAGNOSTIC
> 
> 
> Cheers,
> 
> Patrick

I've seen that aswell, I can't see anything wrong here.
Maybe the compilers check is missguided by fpu_lwp_fork accessing pcb
inderectly via l1/l2 and not directly like in the old code?

para


-----
You will continue to suffer
if you have an emotional reaction to everything that is said to you.
True power is sitting back and observing everything with logic.
If words control you that means everyone else can control you.
Breathe and allow things to pass.

--- Bruce Lee