Re: What to do with base X11 for netbsd-9 ?

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, May 29, 2019 at 07:27:32AM -0500, John D. Baker wrote:
> The
> couple of times I've fired up 'mpv' it worked but seemed to complain
> about software rendering and dumped core on exit.

In my experience, mpv always dumps core when exiting, but it's a
problem in X.

When using modular X, the attached debugging patch that just adds some
printfs made the problem disappear (or at least hide). I don't
understand the root cause, nor have I tried porting the patch to native X.
 Thomas

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/MesaLib/distinfo,v
retrieving revision 1.120
diff -u -r1.120 distinfo
--- distinfo	22 Mar 2017 20:22:31 -0000	1.120
+++ distinfo	2 Jul 2017 22:04:38 -0000
@@ -6,7 +6,7 @@
 Size (mesa-11.2.2.tar.xz) = 7860932 bytes
 SHA1 (patch-configure) = 87f0f2e60f342c91b3aecab02d3a4d8940eadf0a
 SHA1 (patch-include_GL_glxext.h) = 830902f2d38a8395cda682c059fc5223e1b0e89e
-SHA1 (patch-src_compiler_glsl_builtin__functions.cpp) = 1be4e67eda2105f375942c2991cf432e5d74e597
+SHA1 (patch-src_compiler_glsl_builtin__functions.cpp) = 8cb86cda4e25c9a79787f27f0556b1fa53a4e683
 SHA1 (patch-src_egl_drivers_dri2_platform__drm.c) = 99b6dd6739c29551ae2c885eabd7babd159fc3e5
 SHA1 (patch-src_egl_drivers_dri2_platform__x11.c) = 04b6ef8e755f226fbe3e6f2bea6c9e2a56a783ca
 SHA1 (patch-src_egl_main_eglglobals.c) = 2d81ae27f09162d23bc684456cc5fef48c042652
Index: patches/patch-src_compiler_glsl_builtin__functions.cpp
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/MesaLib/patches/patch-src_compiler_glsl_builtin__functions.cpp,v
retrieving revision 1.2
diff -u -r1.2 patch-src_compiler_glsl_builtin__functions.cpp
--- patches/patch-src_compiler_glsl_builtin__functions.cpp	15 Jan 2017 00:14:21 -0000	1.2
+++ patches/patch-src_compiler_glsl_builtin__functions.cpp	2 Jul 2017 22:04:38 -0000
@@ -4,11 +4,28 @@
 
 --- src/compiler/glsl/builtin_functions.cpp.orig	2016-05-09 12:51:42.000000000 +0000
 +++ src/compiler/glsl/builtin_functions.cpp
-@@ -853,6 +853,7 @@ builtin_builder::builtin_builder()
+@@ -852,7 +852,10 @@ builtin_builder::builtin_builder()
+ 
  builtin_builder::~builtin_builder()
  {
++printf("builtin_builder::~builtin_builder in\n");
     ralloc_free(mem_ctx);
 +   mem_ctx = NULL;
++printf("builtin_builder::~builtin_builder out\n");
  }
  
  ir_function_signature *
+@@ -896,11 +899,13 @@ builtin_builder::initialize()
+ void
+ builtin_builder::release()
+ {
++printf("builtin_builder::release in\n");
+    ralloc_free(mem_ctx);
+    mem_ctx = NULL;
+ 
+    ralloc_free(shader);
+    shader = NULL;
++printf("builtin_builder::release out\n");
+ }
+ 
+ void