Re: upgrading via source from 7.1.2 dependencies

[oskar%fessel.org@localhost]

> Am 11.11.2018 um 16:34 schrieb Robert Swindells <rjs%fdy2.co.uk@localhost>:
> 
> 
> Greg Troxel <gdt%lexort.com@localhost> wrote:
>> [need xsrc to build]
>> 
>> I am guessing that the tool build is trying to build some X tools, even
>> if later they will not be used.  If this is right, I see two options for
>> you
>> 
>> 1) conditionalize the tools build to not build the x tools if MKX11 is
>> off.
> 
> It looks to be conditional to me.
> 
> src/tools/Makefile has:
> 
> .if ${MKX11} != "no" 
> SUBDIR+=        makestrs
> SUBDIR+=        makekeys
> .endif

indeed, this is conditional. 
Unfortunately, at least in my copy, MKX11 gets only set to yes with build.sh -x.
The documented „MKX11 defaults to no“ is nowhere explicitly set. 
So the Makefiles where it is used always evaluate the .if clause to true, adding the subdirs.  
Shouldn’t the dependency be „.if ${MKX11} == „yes““?

Anyhow, i just synced xsrc to match the sources and so far this seems to work.

Cheers
	Oskar

Attachment: smime.p7s
Description: S/MIME cryptographic signature