Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: SIOC[GZ]IFDATA fix



    Date:        Tue, 11 Sep 2018 18:49:37 +0900
    From:        Masanobu SAITOH <msaitoh%execsw.org@localhost>
    Message-ID:  <b965c16e-ff60-7592-3975-40a2770bb6a5%execsw.org@localhost>

  | OK?

Looks broken to me.   SIOCGIFDATA and OSIOCGIFDATA (etc)
take different structs as args - treating them as aliases cannot possibly
be correct, can it?

The function already uses 
        struct oifdatareq *ifdr = data;
whcih suggests it is not handling the SIOC forms at all, they would
have a struct ifdatareq * as the data.

Perhaps the problem is that only the Oxxx forms should be handled
in that function, and all that is needed to fix it is to add an O to the
ioctl names ?

kre



Home | Main Index | Thread Index | Old Index