Re: missing break in usbioctl

[Nick Hudson <skrll%netbsd.org@localhost>]

On 09/01/17 15:49, sc dying wrote:
> It looks like case USB_REQUEST in usbioctl() of usb.c misses `break.'
>
> --- sys/dev/usb/usb.c Sun Jan 29 02:28:16 2017
> +++ sys/dev/usb/usb.c Mon Aug 28 08:53:56 2017
> @@ -775,6 +775,7 @@ usbioctl(dev_t devt, u_long cmd, void *d
>    len = UGETW(ur->ucr_request.wLength);
>    kmem_free(ptr, len);
>    }
> + break;
>    }
>
>    case USB_DEVICEINFO:
>
>
> (sorry for tab breakage)
>
> netbsd-7 and netbsd-8 has same problem.
Good catch.



[pullup-7 #1502]

[pullup-8 #262]

Thanks,
NIck