Re: memtestplus

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Mon, Jun 05, 2017 at 11:54:04AM -0400, M. Levinson wrote:
> On Jun 5, 2017, at 1:09pm, Patrick Welche writes:
> >memtestplus starts on boot, I am given the option for safe mode, but come
> >what may, as soon as testing starts, the laptop reboots.
> 
> I saw the same symptom you're seeing, and I found that the smp_find_cpus()
> function in smp.c simply didn't work on my system. Since the failure isn't
> detected and act_cpus is initialized to 0, memtest rebooted after a division
> by zero at line 1159 in main.c:
> 
> 	case 7: /* Block move */
> 		ticks = (ch + ch/act_cpus + c*ch);
> 		break;
> 
> I crudely sidestepped the problem by forcing it to always use only one CPU:
> 
> diff --git a/smp.h b/smp.h
> --- a/smp.h
> +++ b/smp.h
> @@ -7,7 +7,7 @@
>  #define _SMP_H_
>  #include "stdint.h"
>  #include "defs.h"
> -#define MAX_CPUS 32
> +#define MAX_CPUS 1
>  
>  #define FPSignature ('_' | ('M' << 8) | ('P' << 16) | ('_' << 24))

The above worked for me on -current/amd64! This particular laptop
has an Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, so I also tried
MAX_CPUS 2, which failed.

As an aside, should

  multiboot memtestplus maxcpus=1

have worked? (Never tried multiboot.)

Cheers,

Patrick