Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: re(4) bpf-related assert



On Fri, Feb 17, 2017 at 07:50:26PM +0900, Ryota Ozaki wrote:
> 
> Sorry, I forgot to make re use the deferred if_start mechanism.
> 
> Could you try the patch?
>   ozaki-r
> 
> diff --git a/sys/dev/ic/rtl8169.c b/sys/dev/ic/rtl8169.c
> index 691afa4..d262af1 100644
> --- a/sys/dev/ic/rtl8169.c
> +++ b/sys/dev/ic/rtl8169.c
> @@ -869,6 +869,7 @@ re_attach(struct rtk_softc *sc)
>          * Call MI attach routine.
>          */
>         if_attach(ifp);
> +       if_deferred_start_init(ifp, NULL);
>         ether_ifattach(ifp, eaddr);
> 
>         rnd_attach_source(&sc->rnd_source, device_xname(sc->sc_dev),
> @@ -1496,8 +1497,8 @@ re_intr(void *arg)
>                 }
>         }
> 
> -       if (handled && !IFQ_IS_EMPTY(&ifp->if_snd))
> -               re_start(ifp);
> +       if (handled)
> +               if_schedule_deferred_start(ifp);
> 
>         rnd_add_uint32(&sc->rnd_source, status);

I will, thanks!
I hope I can reproduce it.


Home | Main Index | Thread Index | Old Index