Re: -current MKTPM=1 build failure

[christos%astron.com@localhost (Christos Zoulas)]

In article <03491b40-c370-dc50-af44-8a42d8e496a7%spg.tu-darmstadt.de@localhost>,
Hauke Fath  <hf%spg.tu-darmstadt.de@localhost> wrote:
>During a -current build with MKTPM=1, I have run into

Go for it please!

christosx
>
>[...]
>--- tpm_nvread.o ---
>#   compile  tpm_nvread/tpm_nvread.o
>/var/tmp/netbsd-builds/developer/amd64/tools/bin/x86_64--netbsd-gcc -O2 
>-fPIE    -std=gnu99   -Werror 
>--sysroot=/var/tmp/netbsd-builds/developer/amd64/destdi
>/local/source/netbsd-developer/crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c: 
>In function 'main':
>/local/source/netbsd-developer/crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c:273:49: 
>error: 'S_IRUSR' undeclared (first use in this function)
>    fd = open(filename, O_WRONLY|O_TRUNC|O_CREAT, S_IRUSR|S_IWUSR);
>                                                  ^
>/local/source/netbsd-developer/crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c:273:49: 
>note: each undeclared identifier is reported only once for e
>/local/source/netbsd-developer/crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c:273:57: 
>error: 'S_IWUSR' undeclared (first use in this function)
>    fd = open(filename, O_WRONLY|O_TRUNC|O_CREAT, S_IRUSR|S_IWUSR);
>                                                          ^
>--- dependall-usr.bin ---
>/var/tmp/netbsd-builds/developer/amd64/tools/bin/nbctfconvert -g -L 
>VERSION setemul.o
>--- dependall-crypto/external ---
>*** [tpm_nvread.o] Error code 1
>
>nbmake[10]: stopped in 
>/local/source/netbsd-developer/crypto/external/cpl/tpm-tools/bin/tpm_nvread
>
>
>which the following patch fixes
>
>Index: crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c
>===================================================================
>RCS file: 
>/cvsroot/src/crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c,v
>retrieving revision 1.1.1.1
>diff -u -u -r1.1.1.1 tpm_nvread.c
>--- crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c 
>28 Jan 2012 02:57:29 -0000      1.1.1.1
>+++ crypto/external/cpl/tpm-tools/dist/src/tpm_mgmt/tpm_nvread.c 
>12 Jan 2017 14:37:42 -0000
>@@ -23,6 +23,7 @@
>  #include <ctype.h>
>  #include <fcntl.h>
>  #include <unistd.h>
>+#include <sys/stat.h>
>
>  #include "tpm_nvcommon.h"
>  #include "tpm_tspi.h"
>
>-- okay to commit?
>
>Cheerio,
>hauke
>
>-- 
>      The ASCII Ribbon Campaign                    Hauke Fath
>()     No HTML/RTF in email	        Institut für Nachrichtentechnik
>/\     No Word docs in email                     TU Darmstadt
>      Respect for open standards              Ruf +49-6151-16-21344
>