Re: Fwd: Re: drmkms panic

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sat, Aug 06, 2016 at 09:36:49AM +0200, Stefan Hertenberger wrote:
> Von: Stefan Hertenberger <stefan@hertenberger.bayern>
> Gesendet: 5. August 2016 22:46:31 MESZ
> An: coypu%sdf.org@localhost
> Betreff: Re: drmkms panic
> 
> Am , schrieb coypu%SDF.ORG@localhost:
> > 
> > 
> > The problem is pretty obvious. netbsd kmem_alloc doesn't like 
> > allocating
> > zero-sized things, whereas linux kmalloc does.
> > 
> > Now for patching the code to return a sane value provided a zero 
> > size...
> 
> i did a bit of testing and add a little patch,
> 
> Index: dist/drm/drm_gem.c
> ===================================================================
> RCS file: /cvsroot/src/sys/external/bsd/drm2/dist/drm/drm_gem.c,v
> retrieving revision 1.5
> diff -u -r1.5 drm_gem.c
> --- dist/drm/drm_gem.c	18 Aug 2014 01:21:03 -0000	1.5
> +++ dist/drm/drm_gem.c	5 Aug 2016 20:45:48 -0000
> @@ -154,6 +154,7 @@
>   	drm_gem_private_object_init(dev, obj, size);
> 
>   #ifdef __NetBSD__
> +	if (size == 0) return 0;

Try:
  if (size == 0) size = 1;

instead?

Joerg