Re: go vs. NetBSD ELF

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Sun, 1 Nov 2015 14:39:15 +0100
    From:        Thomas Klausner <wiz%NetBSD.org@localhost>
    Message-ID:  <20151101133915.GA19514%danbala.tuwien.ac.at@localhost>

  | Ideas how to fix this?

I'd suggest ...  (src/sys/kern/exec_elf.c)

--- exec_elf.c.was	2015-08-09 01:37:37.000000000 +0700
+++ exec_elf.c	2015-11-01 22:14:16.000000000 +0700
@@ -994,7 +994,7 @@
 		default:
 			BADNOTE("unknown tag");
 bad:
-#ifdef DIAGNOSTIC
+#ifdef __DIAGNOSTIC
 			/* Ignore GNU tags */
 			if (np->n_namesz == ELF_NOTE_GNU_NAMESZ &&
 			    memcmp(ndata, ELF_NOTE_GNU_NAME,


or something similar (the idea is that __DIAGNOSTIC is never defined)
and simply make the diagnostic go away.

I get them from old NetBSD compiled binaries too - the messages change
nothing, everything still seems to work just fine, but they're annoying.

kre