Re: kernel build failure

[B Harder <brad.harder%gmail.com@localhost>]

Patch that builds -- at a glance, it looks like it meets intent.

kamloops# cvs diff ./sys/dev/pcmcia/if_malo_pcmcia.c
Index: ./sys/dev/pcmcia/if_malo_pcmcia.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pcmcia/if_malo_pcmcia.c,v
retrieving revision 1.4
diff -r1.4 if_malo_pcmcia.c
1860c1860
<                   device_xname(sc->sc_dev), body->status);
---
>                       device_xname(sc->sc_dev), body->status);
1862c1862
<       } else
---
>       } else {
1864c1864,1865
<                   device_xname(sc->sc_dev));
---
>                       device_xname(sc->sc_dev));
>       }


On 4/21/14, B Harder <brad.harder%gmail.com@localhost> wrote:
> --- if_loop.o ---
> /usr/src/obj/tooldir.NetBSD-6.99.40-amd64/bin/x86_64--netbsd-gcc
> -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -mno-avx -msoft-float
> -ffreestanding -fno-zero-initialized-in-bss -O2
> -fno-omit-frame-pointer -fstack-protector -Wstack-protector --param
> ssp-buffer-size=1 -fno-strict-aliasing -fno-common -std=gnu99 -Werror
> -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith
> -Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition
> -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code
> -Wno-pointer-sign -Wno-attributes -Wextra -Wno-unused-parameter
> -Wold-style-definition -Wno-sign-compare
> --sysroot=/usr/src/obj/destdir.amd64 -Damd64 -Dx86_64 -I.
> -I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys
> -nostdinc -DDIAGNOSTIC -DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT
> -std=gnu99 -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
> -I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
> -I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/x86_64/string
> -D_FORTIFY_SOURCE=2 -I/usr/src/sys/external/bsd/ipf
> -I/usr/src/sys/external/isc/atheros_hal/dist
> -I/usr/src/sys/external/isc/atheros_hal/ic
> -I/usr/src/sys/external/bsd/drm/dist/bsd-core
> -I/usr/src/sys/external/bsd/drm/dist/shared-core
> -I/usr/src/sys/../common/include
> -I/usr/src/sys/external/bsd/acpica/dist/include -c
> /usr/src/sys/net/if_loop.c
> --- if_malo_pcmcia.o ---
> /usr/src/sys/dev/pcmcia/if_malo_pcmcia.c: In function
> 'cmalo_cmd_rsp_assoc':
> /usr/src/sys/dev/pcmcia/if_malo_pcmcia.c:1864:32: error: suggest
> braces around empty body in an 'else' statement [-Werror=empty-body]
>        device_xname(sc->sc_dev));
>                                 ^
> cc1: all warnings being treated as errors
> *** [if_malo_pcmcia.o] Error code 1
>
> nbmake: stopped in /usr/obj/sys/arch/amd64/compile/GENERIC
> --- if_loop.o ---
> : ctfconvert -g -L VERSION if_loop.o
> --- if_lmc.o ---
> : ctfconvert -g -L VERSION if_lmc.o
> --- if_iwn.o ---
> : ctfconvert -g -L VERSION if_iwn.o
> 1 error
>
>
> --
> Brad Harder
> Method Logic Digital Consulting
> http://twitter.com/bcharder
>


-- 
Brad Harder
Method Logic Digital Consulting
http://www.methodlogic.net/
http://twitter.com/bcharder