Re: NetBSD/amd64 current with HAVE_GCC=48

[Ryota Ozaki <ozaki-r%NetBSD.org@localhost>]

Hi,

The below patch should fix the error, but there may be another
better solution.

Anyone any ideas?

  ozaki-r

Index: external/cddl/osnet/dist/uts/common/dtrace/dtrace.c
===================================================================
RCS file: /cvs/cvsroot/src/external/cddl/osnet/dist/uts/common/dtrace/dtrace.c,v
retrieving revision 1.25
diff -u -r1.25 dtrace.c
--- external/cddl/osnet/dist/uts/common/dtrace/dtrace.c 5 Mar 2014
20:14:15 -0000       1.25
+++ external/cddl/osnet/dist/uts/common/dtrace/dtrace.c 7 Mar 2014
00:28:47 -0000
@@ -16682,6 +16682,7 @@
        cv_signal(&w->cv);
        mutex_exit(&w->lock);
        error = kthread_join(w->lwp);
+       (void) error; /* XXX gcc 4.8 */
        KASSERT(error == 0);
        cv_destroy(&w->cv);
        mutex_destroy(&w->lock);

On Fri, Mar 7, 2014 at 12:06 AM, Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost> 
wrote:
> Hi,
>
> The fresh build of NetBSD/amd64 current with HAVE_GCC=48 and MKDTRACE=yes
> fails as following.
> # I know amd64 does not migrate gcc 4.8 yet.
>
> #   compile  dtrace/dtrace.o
> /usr/tools/amd64/bin/x86_64--netbsd-gcc -O2 -std=gnu99  -Wall 
> -Wstrict-prototype
> s -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare  -Wno-traditional  
> -Wa,
> --fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings 
> -We
> xtra -Wno-unused-parameter -Wno-sign-compare -Werror   -ffreestanding  
> -fno-stri
> ct-aliasing -Wno-pointer-sign -mno-red-zone -mcmodel=kernel 
> -fno-omit-frame-poin
> ter  -I/usr/src/common/include --sysroot=/usr/NewWorld/amd64 
> -I/usr/src/external
> /cddl/osnet/sys  -I/usr/src/external/cddl/osnet/dev/dtrace  
> -I/usr/src/external/
> cddl/osnet/dev/dtrace/amd64  -I/usr/src/external/cddl/osnet/dist/uts/common  
> -DD
> IS_MEM -DSMP -DDEBUG -Wno-unknown-pragmas  -nostdinc -I. 
> -I/usr/src/sys/modules/
> dtrace/dtrace -isystem /usr/src/sys -isystem /usr/src/sys/arch -isystem 
> /usr/src
> /sys/../common/include -D_KERNEL -D_LKM -D_MODULE -DSYSCTL_INCLUDE_DESCR -c   
>  /
> usr/src/external/cddl/osnet/dist/uts/common/dtrace/dtrace.c
> /usr/src/external/cddl/osnet/dist/uts/common/dtrace/dtrace.c: In function 
> 'dtrac
> e_state_worker_remove':
> /usr/src/external/cddl/osnet/dist/uts/common/dtrace/dtrace.c:16677:6: error: 
> var
> iable 'error' set but not used [-Werror=unused-but-set-variable]
>   int error;
>       ^
> cc1: all warnings being treated as errors
>
> *** Failed target:  dtrace.o
> *** Failed command: /usr/tools/amd64/bin/x86_64--netbsd-gcc -O2 -std=gnu99 
> -Wall
>  -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare 
> -Wno
> -traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual 
> -W
> write-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror 
> -ffreestan
> ding -fno-strict-aliasing -Wno-pointer-sign -mno-red-zone -mcmodel=kernel 
> -fno-o
> mit-frame-pointer -I/usr/src/common/include --sysroot=/usr/NewWorld/amd64 
> -I/usr
> /src/external/cddl/osnet/sys -I/usr/src/external/cddl/osnet/dev/dtrace 
> -I/usr/sr
> c/external/cddl/osnet/dev/dtrace/amd64 
> -I/usr/src/external/cddl/osnet/dist/uts/c
> ommon -DDIS_MEM -DSMP -DDEBUG -Wno-unknown-pragmas -nostdinc -I. 
> -I/usr/src/sys/
> modules/dtrace/dtrace -isystem /usr/src/sys -isystem /usr/src/sys/arch 
> -isystem
> /usr/src/sys/../common/include -D_KERNEL -D_LKM -D_MODULE 
> -DSYSCTL_INCLUDE_DESCR
>  -c /usr/src/external/cddl/osnet/dist/uts/common/dtrace/dtrace.c
> *** Error code 1
>
> Stop.
>
> --
> Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3