Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Porting DTrace to ARM

On Mar 5, 2014, at 3:12 AM, Ryota Ozaki <> wrote:

> - Replace cpu_id with cpuid in sys/arch/arm
>  - Can I commit the change?

Why?  It's just churn for no reason I can see.

> - Move INKERNEL and FR_* macros from arm/arm/db_trace.c
>  to arm/include/db_machdep.h to refer them in
>  external/cddl/osnet/dev/dtrace/arm/dtrace_isa.c
>  - Is this change appropriate?

Well, we don't use APCS anymore.  AAPCS is the new ABI.
My question is how useful they'll be.

> - Create arch/evbarm/include/cpufunc.h
>  - It just includes arm/cpufunc.h, then
>    #include <machine/cpufunc.h> for evbarm properly
>    as well as i386/amd64
>  - Is this change appropriate?

No.  This makes an assumption that isn't valid, most ports
don't have <machine/cpufunc.h>.  
#ifdef __arm__
#include <arm/cpufunc.h>

> - Have cond_ok in arm/include/armreg.h
>  - Is this appropriate?

I added arm_cond_ok_p 

Home | Main Index | Thread Index | Old Index