Re: compiling kern/atomic_and_64_cas.o failed

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Jan 27, 2014 at 12:44:48PM -0800, Matt Thomas wrote:
> 
> On Jan 27, 2014, at 12:43 PM, Kurt Schreiner <ks%ub.uni-mainz.de@localhost> 
> wrote:
> 
> > On Mon, Jan 27, 2014 at 12:02:07PM -0800, Matt Thomas wrote:
> >> 
> >> On Jan 27, 2014, at 11:25 AM, Kurt Schreiner 
> >> <ks%ub.uni-mainz.de@localhost> wrote:
> >> 
> >>> Hi,
> >>> 
> >>> with -current source updated some minutes ago compiling a kernel for
> >>> i386 failed:
> >>> 
> >>>   compile  kern/atomic_and_64_cas.o
> >>> cc1: warnings being treated as errors
> >>> /u/NetBSD/src/sys/lib/libkern/../../../common/lib/libc/atomic/atomic_and_64_cas.c:
> >>>  In function '__sync_fetch_and_and_8':
> >>> /u/NetBSD/src/sys/lib/libkern/../../../common/lib/libc/atomic/atomic_and_64_cas.c:49:1:
> >>>  error: control reaches end of non-void function
> >>> --- atomic_and_64_cas.o ---
> >>> *** [atomic_and_64_cas.o] Error code 1
> >>> 
> >>> nbmake[1]: stopped in 
> >>> /u/NetBSD/arch/i386/obj/sys/arch/i386/compile/RADIO/lib/kern
> >> 
> >> fixed.
> > yep, this one is fixed, but ther's another one:
> > 
> >    compile  kern/atomic_or_64_cas.o
> > /u/NetBSD/src/sys/lib/libkern/../../../common/lib/libc/atomic/atomic_or_64_cas.c:41:1:
> >  error: conflicting types for '__sync_fetch_and_or_8'
> > cc1: warnings being treated as errors
> > /u/NetBSD/src/sys/lib/libkern/../../../common/lib/libc/atomic/atomic_or_64_cas.c:
> >  In function '__sync_fetch_and_or_8':
> > /u/NetBSD/src/sys/lib/libkern/../../../common/lib/libc/atomic/atomic_or_64_cas.c:49:2:
> >  error: 'return' with a value, in function returning void
> > --- atomic_or_64_cas.o ---
> > *** [atomic_or_64_cas.o] Error code 1
> > 
> > nbmake[1]: stopped in 
> > /u/NetBSD/arch/i386/obj/sys/arch/i386/compile/RADIO/lib/kern
> > 1 error
> > 
> > should be fixed by changing 'void' to 'uint64_t' like so:
> 
> committed.

I'm pretty sure I have the latest version but still see

--- atomic_add_64_cas.o ---
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_add_64_cas.c:38:10:
 error: conflicting types for '__sync_fetch_and_add_8'
uint64_t __sync_fetch_and_add_8(volatile uint64_t *, int64_t);
         ^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_add_64_cas.c:38:10:
 note: '__sync_fetch_and_add_8' is a builtin with type 'long long (volatile 
long long *, long long, ...)'
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_add_64_cas.c:41:1:
 error: conflicting types for '__sync_fetch_and_add_8'
__sync_fetch_and_add_8(volatile uint64_t *addr, int64_t val)
^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_add_64_cas.c:38:10:
 note: '__sync_fetch_and_add_8' is a builtin with type 'long long (volatile 
long long *, long long, ...)'
uint64_t __sync_fetch_and_add_8(volatile uint64_t *, int64_t);
         ^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_add_64_cas.c:41:1:
 error: definition of builtin function '__sync_fetch_and_add_8'
__sync_fetch_and_add_8(volatile uint64_t *addr, int64_t val)
^
3 errors generated.
*** [atomic_add_64_cas.o] Error code 1
nbmake[8]: stopped in /archive/foreign/src/lib/libc
--- atomic_and_64_cas.o ---
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_and_64_cas.c:38:10:
 error: conflicting types for '__sync_fetch_and_and_8'
uint64_t __sync_fetch_and_and_8(volatile uint64_t *, uint64_t);
         ^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_and_64_cas.c:38:10:
 note: '__sync_fetch_and_and_8' is a builtin with type 'long long (volatile 
long long *, long long, ...)'
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_and_64_cas.c:41:1:
 error: conflicting types for '__sync_fetch_and_and_8'
__sync_fetch_and_and_8(volatile uint64_t *addr, uint64_t val)
^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_and_64_cas.c:38:10:
 note: '__sync_fetch_and_and_8' is a builtin with type 'long long (volatile 
long long *, long long, ...)'
uint64_t __sync_fetch_and_and_8(volatile uint64_t *, uint64_t);
         ^
/archive/foreign/src/lib/libc/../../common/lib/libc/atomic/atomic_and_64_cas.c:41:1:
 error: definition of builtin function '__sync_fetch_and_and_8'
__sync_fetch_and_and_8(volatile uint64_t *addr, uint64_t val)
^
3 errors generated.
*** [atomic_and_64_cas.o] Error code 1

 Thomas