Re: ntp_intres (error: not protecting local variables...)

[B Harder <brad.harder%gmail.com@localhost>]

Fixed now (thx christos) with minor patch:



--- ./ntp_intres.c.old  2013-12-31 13:59:32.000000000 -0800
+++ /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c  2013-12-31
13:59:36.000000000 -0800
@@ -686,7 +686,6 @@
        blocking_gni_resp *     gni_resp;
        size_t                  octets;
        size_t                  resp_octets;
-       char *                  host;
        char *                  service;
        char *                  cp;
        int                     rc;


On 12/31/13, B Harder <brad.harder%gmail.com@localhost> wrote:
> I don't know what's going on, but I nuked that part
> (/usr/src/external/bsd/ntp/dist/libntp) of the source dir, and rebuilt
> single-threaded, w/o "-u" (to clear all old .o files) and it's still
> failing.
>
> #   compile  libntp/netof.o
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-gcc -O2
> -std=gnu99  -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wpointer-arith -Wno-sign-compare  -Wno-traditional
> -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual
> -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare
> -Wsign-compare -Wformat=2   -Wno-forma
> t-zero-length  -Werror -Wno-missing-noreturn   -fstack-protector
> -Wstack-protector   --param ssp-buffer-size=1
> --sysroot=/usr/src/obj/destdir.amd64 -DHAVE_CONFIG_H
> -I/usr/src/external/bsd/ntp/include
> -I/usr/src/external/bsd/ntp/dist/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/unix/include
>   -I/usr/src/external/bsd/ntp/dist/lib/isc/nothreads/include -DOPENSSL
> -DWANT_IPV6 -I/usr/src/external/bsd/ntp/dist/sntp/libopts
> -D_FORTIFY_SOURCE=2 -c
> /usr/src/external/bsd/ntp/dist/libntp/netof.c -o netof.o
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-objcopy
> -x   netof.o
> #   compile  libntp/ntp_calendar.o
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-gcc -O2
> -std=gnu99  -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wpointer-arith -Wno-sign-compare  -Wno-traditional
> -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual
> -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare
> -Wsign-compare -Wformat=2   -Wno-forma
> t-zero-length  -Werror -Wno-missing-noreturn   -fstack-protector
> -Wstack-protector   --param ssp-buffer-size=1
> --sysroot=/usr/src/obj/destdir.amd64 -DHAVE_CONFIG_H
> -I/usr/src/external/bsd/ntp/include
> -I/usr/src/external/bsd/ntp/dist/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/unix/include
>   -I/usr/src/external/bsd/ntp/dist/lib/isc/nothreads/include -DOPENSSL
> -DWANT_IPV6 -I/usr/src/external/bsd/ntp/dist/sntp/libopts
> -D_FORTIFY_SOURCE=2 -c
> /usr/src/external/bsd/ntp/dist/libntp/ntp_calendar.c -o ntp_calendar.o
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-objcopy
> -x   ntp_calendar.o
> #   compile  libntp/ntp_intres.o
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-gcc -O2
> -std=gnu99  -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wpointer-arith -Wno-sign-compare  -Wno-traditional
> -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual
> -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare
> -Wsign-compare -Wformat=2   -Wno-forma
> t-zero-length  -Werror -Wno-missing-noreturn   -fstack-protector
> -Wstack-protector   --param ssp-buffer-size=1
> --sysroot=/usr/src/obj/destdir.amd64 -DHAVE_CONFIG_H
> -I/usr/src/external/bsd/ntp/include
> -I/usr/src/external/bsd/ntp/dist/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/unix/include
>   -I/usr/src/external/bsd/ntp/dist/lib/isc/nothreads/include -DOPENSSL
> -DWANT_IPV6 -I/usr/src/external/bsd/ntp/dist/sntp/libopts
> -D_FORTIFY_SOURCE=2 -c
> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c -o ntp_intres.o
> cc1: warnings being treated as errors
> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c: In function
> 'blocking_getnameinfo':
> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c:678:1: error: not
> protecting local variables: variable length buffer
>
> *** Failed target:  ntp_intres.o
> *** Failed command:
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/x86_64--netbsd-gcc -O2
> -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wpointer-arith -Wno-sign-compare -Wno-traditional
> -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual
> -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare
> -Wsign-compare -Wform
> at=2 -Wno-format-zero-length -Werror -Wno-missing-noreturn
> -fstack-protector -Wstack-protector --param ssp-buffer-size=1
> --sysroot=/usr/src/obj/destdir.amd64 -DHAVE_CONFIG_H
> -I/usr/src/external/bsd/ntp/include
> -I/usr/src/external/bsd/ntp/dist/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/include
> -I/usr/src/external/bsd/ntp/dist/lib/isc/unix/in
> clude -I/usr/src/external/bsd/ntp/dist/lib/isc/nothreads/include
> -DOPENSSL -DWANT_IPV6 -I/usr/src/external/bsd/ntp/dist/sntp/libopts
> -D_FORTIFY_SOURCE=2 -c
> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c -o ntp_intres.o
> *** Error code 1
>
> Stop.
> nbmake[9]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>
> *** Failed target:  dependall
> *** Failed command: cd "/usr/src/external/bsd/ntp/lib/libntp";
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/nbmake realall
> *** Error code 1
>
> Stop.
> nbmake[8]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>
> *** Failed target:  dependall-libntp
> *** Failed command: _makedirtarget() { dir="$1"; shift; target="$1";
> shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .)
> this="external/bsd/ntp/lib/"; real="/usr/src/external/bsd/ntp/lib" ;;
> *) this="external/bsd/ntp/lib/${dir}/";
> real="/usr/src/external/bsd/ntp/lib/${dir}" ;; esac; show=${this:-.};
> echo "${target} ===> ${show%/}${1:+ (with: $@)}"; cd "${real}" &&
> /usr/src/obj/tooldir.NetBSD-6.99.28-amd64/bin/nbmake
> _THISDIR_="${this}" "$@" ${target}; }; _makedirtarget libntp dependall
> *** Error code 1
>
> On 12/31/13, B Harder <brad.harder%gmail.com@localhost> wrote:
>> Hrmm... thx for the datapoint. I'll look closer at my own system.
>>
>> -bch
>>
>>
>> On 12/31/13, Chavdar Ivanov <ci4ic4%gmail.com@localhost> wrote:
>>> I did a full build overnight without any problem:
>>>
>>>  % uname -a
>>> NetBSD uksup1.delcam.local 6.99.28 NetBSD 6.99.28 (GENERIC) #5: Mon
>>> Dec 30 00:26:15 GMT 2013
>>> sysbuild@support6.delcam.local:/home/sysbuild/Sysbuild/amd64/obj/home/sysbuild/src/sys/arch/amd64/compile/GENERIC
>>> amd64
>>>
>>> Chavdar Ivanov
>>>
>>> On 31 December 2013 18:10, B Harder <brad.harder%gmail.com@localhost> wrote:
>>>> This has been an outstanding issue on up-to-date -current (amd64) for
>>>> a few days now:
>>>>
>>>>
>>>>
>>>> cc1: warnings being treated as errors
>>>> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c: In function
>>>> 'blocking_getnameinfo':
>>>> /usr/src/external/bsd/ntp/dist/libntp/ntp_intres.c:678:1: error: not
>>>> protecting local variables: variable length buffer
>>>> *** [ntp_intres.o] Error code 1
>>>> nbmake[9]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>>>> 1 error
>>>> nbmake[9]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>>>> *** [dependall] Error code 2
>>>> nbmake[8]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>>>> 1 error
>>>> nbmake[8]: stopped in /usr/src/external/bsd/ntp/lib/libntp
>>>> *** [dependall-libntp] Error code 2
>>>> nbmake[7]: stopped in /usr/src/external/bsd/ntp/lib
>>>> 1 error
>>>> nbmake[7]: stopped in /usr/src/external/bsd/ntp/lib
>>>> *** [dependall-lib] Error code 2
>>>> nbmake[6]: stopped in /usr/src/external/bsd/ntp
>>>
>>>
>>>
>>> --
>>> ----
>>>
>>
>>
>> --
>> Brad Harder
>> Method Logic Digital Consulting
>> http://www.methodlogic.net/
>> http://twitter.com/bcharder
>>
>
>
> --
> Brad Harder
> Method Logic Digital Consulting
> http://www.methodlogic.net/
> http://twitter.com/bcharder
>


-- 
Brad Harder
Method Logic Digital Consulting
http://www.methodlogic.net/
http://twitter.com/bcharder