Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Marvell 88E1149 PHY working with makphy?

On Mon, Jul 15, 2013 at 05:01:27PM -0400, Thor Lancelot Simon wrote:
> On Mon, Jul 15, 2013 at 01:01:51PM -0500, John D. Baker wrote:
> > 
> > I discovered all this today and enabled "ukphy" to get more information
> > and perhaps make it work better.  That confirmed which PHY I had.  Then
> > I flipped the "#if" test in "makphy.c" to restore the 88E1149 to the
> > device list and my machine works fine with it.  I know the comment in
> > the commit disabling this specific device says "ukphy" works fine with
> > it.
> Why can't you just use ukphy with this PHY?  Does it not work for you?
> I don't think it's a good idea to re-enable it in the makphy driver
> unless a user who could reproduce the original problem says it's fixed.

I'm the one who disabled it, and it still doesn't work for me
on the box where it didn't work before.

if someone would like to add a check to allow enabling this via a config option,
that would be ok, but please keep the default as disabled.


Home | Main Index | Thread Index | Old Index