building tools

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

Assuming my current source tree is OK, I think an -I/usr/src/sys might
be useful at the tools building stage, then again, if none of you see
a problem building makefs at the tools stage, it may be my source tree...

What I see is that usr.sbin/makefs/msdos.c #includes <fs/msdosfs/denode.h>,
yet the build line includes all directories imaginable including for
instance -I/usr/src/sys/fs/msdosfs, which would be find if the #include
where "denode.h", so it seems you need fs/msdosfs/denode.h
in your destdir, but as tools happens early, that is unlikely, so need
the -I flag?


Ah:

# cvs diff -r 1.4 Makefile.inc 
Index: Makefile.inc
===================================================================
RCS file: /cvsroot/src/usr.sbin/makefs/msdos/Makefile.inc,v
retrieving revision 1.4
retrieving revision 1.5
diff -r1.4 -r1.5
1c1
< #     $NetBSD: Makefile.inc,v 1.4 2013/01/26 00:20:40 christos Exp $
---
> #     $NetBSD: Makefile.inc,v 1.5 2013/01/26 16:50:46 christos Exp $
9c9,12
< CPPFLAGS+= -DMSDOS_EI -I${MSDOS} -I${MSDOS_NEWFS} -I${NETBSDSRCDIR}/sys
---
> CPPFLAGS+= -DMSDOS_EI -I${MSDOS} -I${MSDOS_NEWFS}
> .if !defined(HOSTPROGNAME)
> CPPFLAGS+= -I${NETBSDSRCDIR}/sys
> .endif


So, this change is specifically to not include /usr/src/sys when building
eg makefs as a tool... How is this meant to work?

Cheers,

Patrick