Re: port alpha - build still broken - libarch/alpha_pci_io

[David Laight <david%l8s.co.uk@localhost>]

On Mon, Jan 07, 2013 at 09:44:50PM -0800, Paul Goyette wrote:
> With sources updated just a few minutes ago:
> 
> #   compile  libarch/alpha_pci_io.o
> /build/netbsd-local/tools/x86_64/alpha/bin/alpha--netbsd-gcc -O2 -std=gnu99 
> -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wno-sign-compare  -Wno-traditional  -Wa,--fatal-warnings -Wreturn-type 
> -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter 
> -Wno-sign-compare -Wold-style-definition -Wsign-compare -Wformat=2   
> -Wno-format-zero-length  -Werror  -mieee 
> --sysroot=/build/netbsd-local/dest/alpha  -c    
> /build/netbsd-local/src/lib/libarch/alpha/alpha_pci_io.c -o alpha_pci_io.o
> cc1: warnings being treated as errors
> /build/netbsd-local/src/lib/libarch/alpha/alpha_pci_io.c: In function 
> 'alpha_pci_io_swiz_inb':
> /build/netbsd-local/src/lib/libarch/alpha/alpha_pci_io.c:167:2: error: 
> implicitdeclaration of function 'alpha_mb'
> *** [alpha_pci_io.o] Error code 1
> nbmake: stopped in /build/netbsd-local/src/lib/libarch

Well, alpha_mb is defined in arch/alpha/include/alpha_cpu.h as:
#define alpha_mb() __asm volatile("mb":::"memory")
nothing else in that file has any excuse to be exposed to userland.

alpa_cpu.h is included by cpu.h frame.h pcb.h pte.h vmparam.h
none of which I would expect userspace to include.

Where is a more appropriate place for the memory barriers?

        David

-- 
David Laight: david%l8s.co.uk@localhost