Re: Port i386 will not build with MKDTRACE=yes

[Alan Barrett <apb%netbsd.org@localhost>]

On Sat, 15 Dec 2012, Paul Goyette wrote:
> At the request of Mattias Scheler (tron@), I took a quick look 
> at the build for i386 with 'build.sh -V MKDTRACE=yes release'. 
> There is a problem with nbtool_config.h

This should be fixed now.

tools/libelf/Makefile stores things in CPPFLAGS, and then moves 
the result to HOST_CPPFLAGS, like this:

    CPPFLAGS+= <stuff>
    CPPFLAGS+= <more stuff>
    HOST_CPPFLAGS:= ${CPPFLAGS}
    CPPFLAGS:= # empty

But it's a little more complicated.  It also includes 
${TOOLDIR}/share/compat/defs.mk, which appends to HOST_CPPFLAGS. 
So the overall picture looks more like this, with the part of 
HOST_CPPFLAGS that was supposed to come from compat/defs.mk being 
lost:

    CPPFLAGS+= <stuff>
    .include ${TOOLDIR}/share/compat/defs.mk # sets HOST_CPPFLAGS+=<stuff>
    CPPFLAGS+= <more stuff>
    HOST_CPPFLAGS:= ${CPPFLAGS} # oops, lost the part from compat/defs.mk
    CPPFLAGS:= # empty

I have changed the errant line to this:

    HOST_CPPFLAGS:= ${CPPFLAGS} ${HOST_CPPFLAGS}

I think a better fix would be to use HOST_CPPFLAGS throughout.

--apb (Alan Barrett)