Strange build problem for port evbearm-eb

[Paul Goyette <paul%whooppee.com@localhost>]

While continuing my quest to see how many of our ports are actually 
capable of being built, I ran into the following issue:

# ./build.sh -T /build/netbsd-local/tools/x86_64/evbearm-eb -D 
/build/netbsd-local/dest/evbearm-eb -O /build/netbsd-local/obj/evbearm-eb -R 
/build/netbsd-local/release -m evbearm-eb -j1 -u release
...
obj ===> lib/../external/gpl3/gcc/lib/libgcc/libgcc
nbmake: "/build/netbsd-local/src/share/mk/bsd.files.mk" line 110: Wrong number 
of words (1) in .for substitution list with 2 vars
nbmake: Fatal errors encountered -- cannot continue
nbmake: stopped in /build/netbsd-local/src/external/gpl3/gcc/lib/libgcc/libgcc

A quick glance would seem to indicate that code in bsd.files.mk fails 
because BUILDSYMLINKS either contains an odd number of words, or is 
defined-but-zero-length?

...
.if defined(BUILDSYMLINKS)                                      # {

.for _SL _TL in ${BUILDSYMLINKS}  <<<<<< line 110
BUILDSYMLINKS.s+=       ${_SL}
...


The only code that touches BUILDSYMLINKS is from (starting at line 33) 
in src/external/gpl3/gcc/lib/libgcc/libgcc/Makefile:

...
# These usually just have "foo.S", we need to link from the
# gcc/config/$PLATFORM/foo.asm to it.  So far, only rs6000 uses it,
# so we hack it for now.
#.for file in ${G_LIB2ADD_ST}
.   if ${MACHINE_ARCH} == "powerpc"  # XXX XXX why does the above work?*
.for file in crtsavfpr.S crtresfpr.S crtsavgpr.S crtresgpr.S crtresxfpr.S 
crtresxgpr.S
BUILDSYMLINKS+= ${GNUHOSTDIST}/gcc/config/rs6000/${file:S/.S$/.asm/} ${file}
.endfor
.   endif
...


I can't see how this would ever actually get executed, since for this 
build MACHINE_ARCH would/should be set to "earmeb" (in build.sh).  And 
the same code seems to be executed with '-m evbearm-el' but that build 
succeeds!


I'm obviously missing something - does anyone have a clue with which to 
hit me?   :)



-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------