Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: unable to use LVM with stripes



On Thu, 2 Aug 2012 11:01:08 -0600 (MDT)
"Michael L. Hitch" <mhitch%lightning.msu.montana.edu@localhost> wrote:

>    The following change will fix that, and with that change, it should 
> work.
> 
> --- sys/dev/dm/dm_target_stripe.c       4 Jan 2012 16:05:53 -0000 
> 1.17
> +++ sys/dev/dm/dm_target_stripe.c       2 Aug 2012 16:57:44 -0000
> @@ -128,7 +128,7 @@ dm_target_stripe_init(dm_dev_t * dmv, vo
>           * Parse a string, containing tokens delimited by white space,
>           * into an argument vector
>           */
> -       for (ap = argv; ap < &argv[9] &&
> +       for (ap = argv; ap <= &argv[9] &&
>              (*ap = strsep(&params, " \t")) != NULL;) {
>                  if (**ap != '\0')
>                          ap++;

I see that netbsd-6 has the same issue (and will thus need pullup), can
you please file a PR about this?  I could do it, but I don't use LVM
and will not be able to confirm that the fix works.

Thanks,
-- 
Matt


Home | Main Index | Thread Index | Old Index