Re: Ata & atapi bug

[David Laight <david%l8s.co.uk@localhost>]

On Tue, Jul 10, 2012 at 01:47:43AM +0200, vanoven wrote:
> Hi,
> I got trouble booting with the last kernel on my old nc8000 laptop : my 
> ATA drive was not seen anymore while cdrom drive was.
> 
> after looking in source i found a problem in 
> /cvsroot/src/sys/dev/scsipi/atapi_wdc.c
> 
> with regard to this  diff
> 
> @@ -321,12 +321,12 @@ wdc_atapi_probe_device(struct atapibus_s
>                         ata_probe_caps(drvp);
>                 else {
>                         s = splbio();
> -                       drvp->drive_flags &= ~DRIVE_ATAPI;
> +                       drvp->drive_type = DRIVET_NONE;
>                         splx(s);
>                 }
>         } else {
>                 s = splbio();
> -               drvp->drive_flags &= ~DRIVE_ATAPI;
> +               drvp->drive_type = DRIVET_NONE;
>                 splx(s);
>         }
>  }
> 
> my harddrive is changed from DRIVET_ATA to DRIVET_NONE in the new version.
> I add
>     if ( drvp->drive_type == DRIVET_ATAPI )
>             drvp->drive_type = DRIVET_NONE;
> to fix that
> 
> Hope it can help.

Those two parts of the diff look like error paths - so shouldn't be relevant.
Exactly where did you add the code to set DRIVET_NONE?
Your CDROM will probably need DRIVET_ATAPI.

I applied a small change to the driver yesterday (patch from Manuel)
which fixes issues on a lot of other systems.
Does that one fix yours?

        David

-- 
David Laight: david%l8s.co.uk@localhost