Re: ipmi(4) and negative temperatures

[Paul Goyette <paul%whooppee.com@localhost>]

Looks good to me...

On Mon, 2 Apr 2012, Nicolas Joly wrote:

> Hi,
>
> I finally got some some to look into the envsys framework and ipmi
> driver searching for the reason why it doesn't handle negative
> temperatures.
>
> To summarize, my new amd64 developpement workstation show bogus
> warnmin and critmin limits for system temp (triggering a wrong event).
>
>                      Current  CritMax  WarnMax  WarnMin  CritMin  Unit
>       System Temp:    32.137   77.330   75.321  252.074  250.066 degC
>
> At the same time, ipmitool report the corresponding values as negative
> ones (-5.000 and -7.000), which make sense IMO.
>
> System Temp      | 32.000     | degrees C  | ok    | -9.000    | -7.000    | 
> -5.000    | 75.000    | 77.000    | 79.000
>
> After a few debugging, i noted that ipmi(4) does not take into account
> that sensors can use signed values and always use an unsigned 8bit for
> calculations ...
>
> With the attached patch, the system temp min limits looks ok, and all
> other ones remains unchanged.
>
>                      Current  CritMax  WarnMax  WarnMin  CritMin  Unit
>       System Temp:    32.137   77.330   75.321   -5.021   -7.030 degC
>
> Does this looks ok ?
> Thanks.
>
> --
> Nicolas Joly
>
> Projects and Developments in Bioinformatics
> Institut Pasteur, Paris.
>
>
> !DSPAM:4f79e9ef1981315816492!

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------