Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: New test failures: dev/scsipi/t_cd/noisyeject, dev/sysmon/t_swsensor, etc.

On Fri, Feb 03, 2012 at 05:25:15PM +0200, Andreas Gustafsson wrote:
> A number of new ATF tests failures appeared yesterday: the noisyeject
> test which previously just failed now dumps core, there are several
> new failures under dev/sysmon/t_swsensor and dev/sysmon/t_swwdog.
> These look like they're related to Thor's "Entropy-pool implementation
> move and cleanup" commit.

Now that rnd is not optional anymore, rump miss the needed rnd_init()
call. Otherwise, rnd_attach_source() called from cdattach() will try
to operate on void pool ... kaboom.

The attached patch makes dev/{scsipi,sysmon} tests works on my amd64
dev machine.

Nicolas Joly

Projects and Developments in Bioinformatics
Institut Pasteur, Paris.
Index: sys/rump/librump/rumpkern/rump.c
RCS file: /cvsroot/src/sys/rump/librump/rumpkern/rump.c,v
retrieving revision 1.239
diff -u -p -r1.239 rump.c
--- sys/rump/librump/rumpkern/rump.c    29 Jan 2012 14:57:31 -0000      1.239
+++ sys/rump/librump/rumpkern/rump.c    3 Feb 2012 16:35:10 -0000
@@ -315,6 +315,8 @@ rump__init(int rump_version)
+       rnd_init();
         * Create the kernel cprng.  Yes, it's currently stubbed out
         * to arc4random() for RUMP, but this won't always be so.

Home | Main Index | Thread Index | Old Index