Re: Instability on amd64 -current

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 8 Jan 2012, Gary Duzan wrote:

>   This sounds rather similar to what I was seeing on my box. Chuq is
> looking into the cause, but this patch is a workaround:
>
> Index: sys/arch/amd64/include/types.h
> ===================================================================
> RCS file: /usr2/netbsd-cvs/src/sys/arch/amd64/include/types.h,v
> retrieving revision 1.40
> diff -u -r1.40 types.h
> --- sys/arch/amd64/include/types.h      4 Dec 2011 16:24:13 -0000       1.40
> +++ sys/arch/amd64/include/types.h      8 Jan 2012 15:43:41 -0000
> @@ -95,7 +95,7 @@
> #define __HAVE_RAS
>
> #include "opt_xen.h"
> -#if defined(__x86_64__) && !defined(XEN)
> +#if defined(__x86_64__) && !defined(XEN) && 0
> #define __HAVE_DIRECT_MAP 1
> #define __HAVE_MM_MD_DIRECT_MAPPED_IO
> #define __HAVE_MM_MD_DIRECT_MAPPED_PHYS
> ===================================================================

Thanks, I'll give that a try!

BTW, since the

        #if defined(__x86_64__) && !defined(XEN) && 0

is _already_ inside a

        #if defined(__x86_64__)

(from back near the top of the file), it seems that it could easily be 
reduced to simply

        #if !defined(XEN)
  or    #if !defined(XEN) && 0


:)



-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------