Kernels w/pf compiled in don't build.

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

Since I prefer to use 'pf', I've been enabling the pseudo-devices in
my kernel configs so it is compiled in.

Recent changes cause such kernels not to be buildable, failing with
the following messages:

[...]
--- pf_ioctl.o ---
#   compile  SHADOW/pf_ioctl.o
/d0/nbsd/current/src/..//tools/i386/bin/i486--netbsdelf-gcc -mno-sse -mno-sse2 
-mno-sse3 -ffreestanding -fno-zero-initialized-in-bss -O2 -fstack-protector 
-Wstack-protector --param ssp-buffer-size=1 -fno-strict-aliasing -std=gnu99 
-Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith 
-Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual 
-Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign -Wno-attributes -Wextra 
-Wno-unused-parameter -Wno-sign-compare 
--sysroot=/d0/nbsd/current/src/..//DEST/i386 -Di386 -I. 
-I/d0/nbsd/current/src/sys/../common/include -I/d0/nbsd/current/src/sys/arch 
-I/d0/nbsd/current/src/sys -nostdinc -DDIAGNOSTIC -DRF_INCLUDE_RAID5_RS=1 
-DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -std=gnu99 
-I/d0/nbsd/current/src/sys/lib/libkern/../../../common/lib/libc/quad 
-I/d0/nbsd/current/src/sys/lib/libkern/../../../common/lib/libc/string 
-I/d0/nbsd/current/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
 -I/d0/nbsd/current/src/sys/dist/pf 
-I/d0/nbsd/current/src/sys/external/bsd/drm/dist/bsd-core 
-I/d0/nbsd/current/src/sys/external/bsd/drm/dist/shared-core 
-I/d0/nbsd/current/src/sys/../common/include 
-I/d0/nbsd/current/src/sys/external/bsd/acpica/dist/include -c 
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c
--- pf_ioctl.o ---
cc1: warnings being treated as errors
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c: In function 'pfioctl':
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:2224:22: error: declaration of 
'pa' shadows a previous local
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:1217:22: error: shadowed 
declaration is here
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:2269:22: error: declaration of 
'pa' shadows a previous local
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:1217:22: error: shadowed 
declaration is here
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:2280:22: error: declaration of 
'pa' shadows a previous local
/d0/nbsd/current/src/sys/dist/pf/net/pf_ioctl.c:1217:22: error: shadowed 
declaration is here
*** [pf_ioctl.o] Error code 1

nbmake: stopped in /d0/nbsd/current/obj/i386/sys/arch/i386/compile/SHADOW
1 error

nbmake: stopped in /d0/nbsd/current/obj/i386/sys/arch/i386/compile/SHADOW

ERROR: Failed to make all in 
"/d0/nbsd/current/src/..//obj/i386/sys/arch/i386/compile/SHADOW"
*** BUILD ABORTED ***


Is this some fallout from some of the 'static'-ification I've been
seeing?

--
|/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
| X  No HTML/proprietary data in email.   BSD just sits there and works!
|/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645