Re: Possible unsafe use of strncat in sbin/sysctl/sysctl.c

[David Laight <david%l8s.co.uk@localhost>]

On Tue, Aug 23, 2011 at 11:23:55PM +0200, Jimmy Johansson wrote:
> Hi,
> 
> I propose the following patch, as I think this is what the developer
> intended anyway:
 
I'd try to find a way of avoiding repeated strlcat() - to avoid the
repeated (effective) strlen() calls.

But yes, strncat() is especially broken.

        David

-- 
David Laight: david%l8s.co.uk@localhost