Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Possible unsafe use of strncat in sbin/sysctl/sysctl.c

At 8:22 Uhr +0200 24.8.2011, Marc Balmer wrote:
>> Both cases mean I don't use the return value. But in one case, this is
>> ok, while in the other, it's a bug. Do your compiler know something I
>> don't?
>I think this is not a valid reasoning:  What if I, to silence a tool,
>choose to blindly insert (void), instead of checking the return value?
>I can always create bugs, and spilling (void) all over only helps maybe
>a tiniy fraction of them.

Agreed. (void)foo() seems the moral equivalent of suse's "alias rm '/bin/rm
-i'" to me.

Its main effect is to lower the code's s/n ratio.


"It's never straight up and down"     (DEVO)

Home | Main Index | Thread Index | Old Index