Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Build breakage - port amd64 - lib/bpf_filter.c



In article <201107141236.OAA0000031503%zel459.zel.kfa-juelich.de@localhost>,
Matthias Drochner  <M.Drochner%fz-juelich.de@localhost> wrote:
>
>martin%duskware.de@localhost said:
>> This change is backout-candidate anyway...
>
>Yes, just checked -- OpenBSD doesn't have the validation
>logics for scratch mem locations as we have. So the patch
>is OK there but unneeded for us.
>I'll back it out.

The patch is not OK there. This is a critical performance path and
zeroing out 64 bytes of scratch space on each packet is not the
best way to use CPU cycles.

Thanks for backing it out.

christos



Home | Main Index | Thread Index | Old Index