Re: More build breakage

[Takahiro HAYASHI <hash%abox3.so-net.ne.jp@localhost>]

hi,

On Thu, 17 Feb 2011 23:17:32 -0300
Dennis Ferguson <dennis.c.ferguson%gmail.com@localhost> wrote:

> I'm having this problem with a tree updated at 00:45 UTC.
> i386, amd64 and macppc all agree on the problem.
> 
> #   compile  libgdb/bsd-kvm.o
> [...]
> /usr/NetBSD/src/gnu/dist/gdb6/gdb/bsd-kvm.c: In function 
> 'bsd_kvm_fetch_registers':
> /usr/NetBSD/src/gnu/dist/gdb6/gdb/bsd-kvm.c:226: error: invalid use of 
> undefined type 'struct lwp'
> /usr/NetBSD/src/gnu/dist/gdb6/gdb/bsd-kvm.c: In function 'bsd_kvm_proc_cmd':
> /usr/NetBSD/src/gnu/dist/gdb6/gdb/bsd-kvm.c:290: error: invalid use of 
> undefined type 'struct lwp'

Glancing at and grep'ing srcs,
struct lwp is now excluded from sys/sys/lwp.h unless defined(_KERNEL)
or defined(_KMEMUSER). gdb does not define _KMEMUSER so that libgdb
fails to build.

...and moving lwp_getpcb() into #ifdef _KERNEL in sys/sys/lwp.h
causes build breakage of usr.sbin/crash because it refers
lwp_getpcb() via sys/arch/$arch/$arch/db_trace.c.
I think lwp_getpcb() should be also moved into _KMEMUSER region.

--
Takahiro HAYASHI