Re: Trouble with HP USB Flash Drive

[Gary Duzan <gary%duzan.org@localhost>]

In Message <20101230165614.GA2838%tarantulon.kollasch.net@localhost>,
   "Jonathan A. Kollasch" <jakllsch%kollasch.net@localhost>wrote:

=>On Thu, Dec 30, 2010 at 11:30:37AM -0500, Gary Duzan wrote:
=>>    I just acquired a pile of HP 4GB USB Flash drives (v125w). When
=>> inserted into one of my NetBSD boxes, it gets the geometry, but
=>> then:
=>> 
=>>     sd4: unable to open device, error = 5
=>> 
=>> [ ... ]
=>
=>Looks like another device that may need PQUIRK_NODOORLOCK.
=>This is getting too common.

   You called it; it is much happier now. Patch included below.

   Thanks.

                                        Gary Duzan



Index: sys/dev/usb/umass_quirks.c
===================================================================
RCS file: /usr2/netbsd-cvs/src/sys/dev/usb/umass_quirks.c,v
retrieving revision 1.83
diff -b -u -p -r1.83 umass_quirks.c
--- sys/dev/usb/umass_quirks.c  3 Nov 2010 22:34:24 -0000       1.83
+++ sys/dev/usb/umass_quirks.c  30 Dec 2010 19:13:47 -0000
@@ -277,6 +277,15 @@ Static const struct umass_quirk umass_qu
          UMATCH_VENDOR_PRODUCT,
          NULL, NULL
        },
+
+       /* HP USB pendrives don't like being told to lock the door */
+       { { USB_VENDOR_HP, USB_PRODUCT_HP_V125W },
+         UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC, 
+         0,
+         PQUIRK_NODOORLOCK,
+         UMATCH_VENDOR_PRODUCT,
+         NULL, NULL
+       },
 };
 
 const struct umass_quirk *
Index: sys/dev/usb/usbdevs
===================================================================
RCS file: /usr2/netbsd-cvs/src/sys/dev/usb/usbdevs,v
retrieving revision 1.570
diff -b -u -p -r1.570 usbdevs
--- sys/dev/usb/usbdevs 8 Dec 2010 20:59:58 -0000       1.570
+++ sys/dev/usb/usbdevs 30 Dec 2010 19:13:47 -0000
@@ -1462,6 +1462,7 @@ product HP RNDIS          0x1c1d  Generic RNDIS
 product HP 640C                        0x2004  DeskJet 640c
 product HP 4670V               0x3005  ScanJet 4670v
 product HP P1100               0x3102  Photosmart P1100
+product HP V125W               0x3307  Flash Drive v125w
 product HP 6127                        0x3504  Deskjet 6127
 product HP HN210E              0x811c  Ethernet HN210E
 
Index: sys/dev/usb/usbdevs.h
===================================================================
RCS file: /usr2/netbsd-cvs/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.563
diff -b -u -p -r1.563 usbdevs.h
--- sys/dev/usb/usbdevs.h       8 Dec 2010 21:02:12 -0000       1.563
+++ sys/dev/usb/usbdevs.h       30 Dec 2010 19:13:47 -0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usbdevs.h,v 1.563 2010/12/08 21:02:12 phx Exp $        */
+/*     $NetBSD$        */
 
 /*
  * THIS FILE IS AUTOMATICALLY GENERATED.  DO NOT EDIT.
@@ -1469,6 +1469,7 @@
 #define        USB_PRODUCT_HP_640C     0x2004          /* DeskJet 640c */
 #define        USB_PRODUCT_HP_4670V    0x3005          /* ScanJet 4670v */
 #define        USB_PRODUCT_HP_P1100    0x3102          /* Photosmart P1100 */
+#define        USB_PRODUCT_HP_V125W    0x3307          /* Flash Drive v125w */
 #define        USB_PRODUCT_HP_6127     0x3504          /* Deskjet 6127 */
 #define        USB_PRODUCT_HP_HN210E   0x811c          /* Ethernet HN210E */
 
Index: sys/dev/usb/usbdevs_data.h
===================================================================
RCS file: /usr2/netbsd-cvs/src/sys/dev/usb/usbdevs_data.h,v
retrieving revision 1.564
diff -b -u -p -r1.564 usbdevs_data.h
--- sys/dev/usb/usbdevs_data.h  8 Dec 2010 21:02:12 -0000       1.564
+++ sys/dev/usb/usbdevs_data.h  30 Dec 2010 19:13:47 -0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usbdevs_data.h,v 1.564 2010/12/08 21:02:12 phx Exp $   */
+/*     $NetBSD$        */
 
 /*
  * THIS FILE IS AUTOMATICALLY GENERATED.  DO NOT EDIT.
@@ -4479,6 +4479,10 @@ const struct usb_product usb_products[] 
            "Photosmart P1100",
        },
        {
+           USB_VENDOR_HP, USB_PRODUCT_HP_V125W,
+           "Flash Drive v125w",
+       },
+       {
            USB_VENDOR_HP, USB_PRODUCT_HP_6127,
            "Deskjet 6127",
        },
@@ -8375,4 +8379,4 @@ const struct usb_product usb_products[] 
            "Prestige",
        },
 };
-const int usb_nproducts = 1594;
+const int usb_nproducts = 1595;