Re: fwohci panic at boot

[KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>]

Hi! Christoph,


From: "Christoph Egger" <Christoph_Egger%gmx.de@localhost>
Date: Mon, 17 May 2010 14:30:30 +0200

> I tested the patch and I have another crash now:
> 
> fwohci0: interrupting at ioapic0 pin 22
> fwohci0: OHCI version 1.10 (ROM=1)
> fwohci0: No. of Isochronous channels is 4.
> fwohci0: EUI64 00:11:d8:00:00:d3:db:d5
> fwohci0: Phy 1394a available S400, 2 ports.
> fwohci0: Link S400, max_rec 2048 bytes.
> ieee1394if0 at fwohci0: IEEE1394 bus
> fwip0 at ieee1394if0: IP over IEEE1394
> panic: lockdebug_lookup: uninitialized lock (lock=0xffffffff80d442c8, 
> from=ffffffff802bb05e)

> lockdebug_free() at netbsd:lockdebug_free
> mutex_enter() at netbsd:mutex_enter+0x3d6
> fw_busreset() at netbsd:fw_busreset+0x23f
> firewireattach() at netbsd:firewireattach+0x255


Oops...

firewire.c:firewireattach() ---

        fw_busreset(fc, FWBUSNOTREADY);                 // <<<<-----
  
        :

        if (!newrom_mtx_initialized) {
                /* 
                 * newrom_mtx uses to mutual exclusion for newrom_space in
                 * fw_busreset() globally.
                 */
                mutex_init(&newrom_mtx, MUTEX_DEFAULT, IPL_BIO); // <<<<<---
                newrom_mtx_initialized = 1;
        }

--- firewire.c:firewireattach()

However, my amd64 work now... ;-)
Can you test by moving mutex_init ahead a little more?

Thanks,
--
kiyohara