Re: marvell relation support 20100413

[Frank Wille <frank%phoenix.owl.de@localhost>]

KIYOHARA Takashi wrote:

>> First of all, please make the interrupt of pic of powerpc 64bit
>> supports. Typedef is actually only done though this might influence a
>> lot of port. And, this change was tested with my ofppc.
>> 
>>
>>
ftp://ftp.netbsd.org/pub/NetBSD/misc/kiyohara/orion_nas/support-powerpc-pic-64bit-imask-20100413.diff
>
>> This will be done on the next weekend.
>
> Done.

Did you forget something? After an update I can no longer compile ofppc
kernels:

---8<---
#    create  PEGASOS/assym.h
cat /home/frank/netbsd/current/src/sys/arch/powerpc/oea/genassym.cf  | 
/home/frank/netbsd/current/src/obj/tooldir.NetBSD-3.1.1_PATCH-macppc/bin/nbgenassym
--
/home/frank/netbsd/current/src/obj/tooldir.NetBSD-3.1.1_PATCH-macppc/bin/powerpc--netbsd-gcc
 -mno-strict-align -msoft-float  -Wa,-maltivec -ffreestanding
-fno-zero-initialized-in-bss -g -O2 -std=gnu99 -fno-strict-aliasing  
-Wreturn-type -Werror -Wall -Wno-main -Wno-format-zero-length
-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow
-Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-sign-compare
-Wno-pointer-sign -Wno-attributes  -Werror   -Dofppc=ofppc -I. 
-I/home/frank/netbsd/current/src/sys/../common/include
-I/home/frank/netbsd/current/src/sys/arch 
-I/home/frank/netbsd/current/src/sys -nostdinc -DFIRMWORKSBUGS
-DTRAP_PANICWAIT -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT
-I/home/frank/netbsd/current/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/home/frank/netbsd/current/src/sys/lib/libkern/../../../common/lib/libc/string
-I/home/frank/netbsd/current/src/sys/lib/libkern/../../../common/lib/libc/arch/powerpc/string
  -I/home/frank/netbsd/current/src/sys/dist/ipf   > assym.h.tmp &&  mv -f
assym.h.tmp assym.h
In file included from ./machine/cpu.h:41,
                 from ./powerpc/param.h:42,
                 from ./machine/param.h:4,
                 from /home/frank/netbsd/current/src/sys/sys/param.h:164,
                 from /tmp/genassym.9280/assym.c:5:
./powerpc/cpu.h:77: error: expected ':', ',', ';', '}' or '__attribute__'
before 'ci_ipending'
---8<---

Seems that imask_t, used with ci_ipending, is not known. I searched the
whole source and found imask_t only defined in:

sys/arch/powerpc/include/ibm4xx/ibm4xx_intr.h

-- 
Frank Wille