Re: crash build problem

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

Christos Zoulas wrote:
> In article <20091121163454.GD4183%quitz.inf.phy.cam.ac.uk@localhost>,
> Patrick Welche  <prlw1%cam.ac.uk@localhost> wrote:
>> Building -current/i386 stops in
>>
>> #   compile  crash/db_trace.o
>> /usr/src/obj.i386/tooldir.NetBSD-5.99.22-i386/bin/i486--netbsdelf-gcc
>> -O2 -pipe  -Wall -Wstrict-prototypes -Wmissing-prototypes
>> -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wa,--fatal-warnings
>> -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra
>> -Wno-unused-parameter -Wsign-compare -std=gnu99  -Werror
>> "-march=pentium4"  -I/usr/src/usr.sbin/crash
>> -I/usr/src/usr.sbin/crash/obj.i386 -I/usr/src/usr.sbin/crash/../../sys
>> -fno-strict-aliasing -DDDB_VERBOSE_HELP -DDB_MAX_LINE=10000000
>> -D_KMEMUSER -nostdinc -isystem /usr/include   -c   
>> /usr/src/usr.sbin/crash/../../sys/arch/i386/i386/db_trace.c
>> cc1: warnings being treated as errors
>> /usr/src/usr.sbin/crash/../../sys/arch/i386/i386/db_trace.c: In function
>> 'db_stack_trace_print':
>> /usr/src/usr.sbin/crash/../../sys/arch/i386/i386/db_trace.c:456:
>> warning: implicit declaration of function 'lwp_getpcb'
>> /usr/src/usr.sbin/crash/../../sys/arch/i386/i386/db_trace.c:456:
>> warning: assignment makes pointer from integer without a cast
>> *** Error code 1
>>
>>
>> I tried
>>
>> Index: db_trace.c
>> ===================================================================
>> RCS file: /cvsroot/src/sys/arch/i386/i386/db_trace.c,v
>> retrieving revision 1.64
>> diff -u -r1.64 db_trace.c
>> --- db_trace.c  21 Nov 2009 03:11:00 -0000      1.64
>> +++ db_trace.c  21 Nov 2009 16:31:49 -0000
>> @@ -33,6 +33,7 @@
>> #include <sys/systm.h>
>> #include <sys/proc.h>
>> #include <sys/intr.h> 
>> +#include <sys/lwp.h>
>> #include <sys/cpu.h> 
>>
>> #include <machine/db_machdep.h>
>>
>>
>> as lwp_getpcb is defined there, but no change?! Now I'm mistified: explicit
>> addition of the header didn't seem to get rid of the "implicit declaration"
>> warning.
>>
>> What have I missed?
>>
> 
> Kernel only function?

Fixed by this commit:

-------------------------------------
Module Name:    src
Committed By:   dsl
Date:           Sat Nov 21 19:59:51 UTC 2009

Modified Files:
        src/sys/arch/i386/i386: db_trace.c

Log Message:
Don't call lwp_getpcb() when not KERNEL.


To generate a diff of this commit:
cvs rdiff -u -r1.64 -r1.65 src/sys/arch/i386/i386/db_trace.c
-------------------------------------

Christoph