Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

xorg pixman testers wanted



Hi,

there an issue with the cpu specific code which is used on i386 and amd64:
* Michael Hitch mentioned that the -msse optimization flag for pixman-mmx.c
  is causing problems for him on i386
* i386 can't build the pixman-sse2.c code, due too the gcc version which
  we use. Thats why I removed the sse2 code from the SRCS list on i386.
* amd64 could use see2 but we currently have that part disabled in config.h
  So enable it there, but only for amd64.

For that I need some testers who can rebuild pixman with the attached
patch on both systems. Be warned that this patch is completely untested.

Regards,
Bernd

Index: src/external/mit/xorg/lib/pixman/Makefile
===================================================================
RCS file: /cvsroot/src/external/mit/xorg/lib/pixman/Makefile,v
retrieving revision 1.9
diff -b -u -r1.9 Makefile
--- src/external/mit/xorg/lib/pixman/Makefile   9 Jul 2009 02:15:48 -0000       
1.9
+++ src/external/mit/xorg/lib/pixman/Makefile   17 Oct 2009 05:55:08 -0000
@@ -37,12 +37,17 @@
 
 # XXX
 
-.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
+.if ${MACHINE_ARCH} == "i386"
+# SSE2 requires a gcc >= 4.2
+SRCS+= pixman-mmx.c
+COPTS.pixman-mmx.c=    -mmmx -fvisibility=hidden
+MKDEPFLAGS+=           -mmmx -fvisibility=hidden
+.elif ${MACHINE_ARCH} == "x86_64"
 SRCS+= pixman-mmx.c
 SRCS+= pixman-sse2.c
-MKDEPFLAGS+=           -msse -mmmx -fvisibility=hidden
-COPTS.pixman-mmx.c=    -msse -mmmx -fvisibility=hidden
-COPTS.pixman-sse2.c=   -msse -mmmx -fvisibility=hidden
+COPTS.pixman-mmx.c=    -mmmx -fvisibility=hidden
+COPTS.pixman-sse2.c=   -msse2 -fvisibility=hidden
+MKDEPFLAGS+=           -mmmx -msse2 -fvisibility=hidden
 .endif
 
 # .if VMX
Index: xsrc/external/mit/pixman/include/config.h
===================================================================
RCS file: /cvsroot/xsrc/external/mit/pixman/include/config.h,v
retrieving revision 1.2
diff -b -u -r1.2 config.h
--- xsrc/external/mit/pixman/include/config.h   30 Oct 2008 08:15:40 -0000      
1.2
+++ xsrc/external/mit/pixman/include/config.h   17 Oct 2009 05:55:26 -0000
@@ -58,9 +58,11 @@
 #if defined(__i386__) || defined(__x86_64__)
 /* use MMX compiler intrinsics */
 #define USE_MMX 1
+#endif
 
+#if defined(__x86_64__)
 /* use SSE2 compiler intrinsics */
-/* #undef USE_SSE2 */
+#define USE_SSE2 1
 #endif
 
 /* use VMX compiler intrinsics */


Home | Main Index | Thread Index | Old Index