Re: if_iwn.c patch to support the 5100... (analysis + patch)

[Brett Lymn <blymn%baesystems.com.au@localhost>]

On Thu, Sep 17, 2009 at 09:39:20AM -0600, Sverre Froyen wrote:
> 
> It looks like these errors may be because iwn_init is called a second time 
> before the first call has completed.  It is called via the "if_init" pointer 
> and also through iwn_ioctl.  The call via the ioctl path only happens if the 
> IFF_UP is set.  I notice that, e.g., net/if_ethersubr.c sets this flag before 
> the call to if_init.  While this seems counterintuitive to me it is appears 
> to 
> be the way it's always worked.  The simplest fix is to remove the call to 
> iwn_init from iwn_ioctl:
> 

Doesn't that have the unfortunate side effect of you then being unable
to reset the interface by doing an ifconfig down/up?

If the double init is really the problem then why not serialise access
to the function?

-- 
Brett Lymn
"Warning:
The information contained in this email and any attached files is
confidential to BAE Systems Australia. If you are not the intended
recipient, any use, disclosure or copying of this email or any
attachments is expressly prohibited.  If you have received this email
in error, please notify us immediately. VIRUS: Every care has been
taken to ensure this email and its attachments are virus free,
however, any loss or damage incurred in using this email is not the
sender's responsibility.  It is your responsibility to ensure virus
checks are completed before installing any data sent in this email to
your computer."