Re: SMSC LAN9118 Family driver

[KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>]

Hi! Tsutsui-san,


From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
Date: Fri, 17 Jul 2009 21:35:56 +0900

> > I will commit the support for 'SMSC LAN9118 Family driver'(slan) at
> > next week.
> 
> I'm still afraid some people might complain that the name 'slan'
> is too generic and ambiguous. (it could imply something like vlan(4))
> 
> How about smh(4)?
> - we already have sm(4) for SMC 91c100/91c96 (FEAST)
> - SMSC calls 9115/9116/9117/9118  "High Performance" or "Highly Efficient"
>   http://www.smsc.com/index.php?tid=145
>   (I guess that's because many people claim the FEAST is
>    the "worst" controller, as src/sys/dev/ic/rtl81x9.c says ;-p)

hmm.  I propose smsh(4) though it is trifling.

  sm(4) -> SMC's ethernet controller
           ^^
  smsh(4) -> SMSC's "High *" ethernet controller
             ^^^     ^

> >+    val = bus_space_read_4(sc->sc_iot, sc->sc_ioh, LAN9118_BYTE_TEST);
> >+    if (sc->sc_flags & LAN9118_FLAGS_SWAP)
> >+            val = bswap32(val);
> >+    if (val != LAN9118_BYTE_TEST_VALUE) {
> >+            aprint_error_dev(sc->sc_dev, "failed to detect chip\n");
> >+            return EINVAL;
> >+    }
> 
> I wonder if LAN9118_FLAGS_SWAP should be handled by MD bus_space(9) or not.

I think that I am significant to the use of the function of LSI as an
approach different from bus_space(9).


> BTW, do you have a backend driver for ISA variants?
> If not, it should not be mentioned in man page yet.

Should I delete the description concerning ISA?
I should describe 'It operates on the evbarm board.  Maybe works on ISA-
bus.  However not exists the ISA back end yet'.


Thanks,
--
kiyohara