Re: ld at sdmmc

[Jasper Wallace <jasper%pointless.net@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 15 Sep 2008, Jared D. McNeill wrote:

> On Mon, 15 Sep 2008, Jared D. McNeill wrote:
> > On Mon, 15 Sep 2008, Quentin Garnier wrote:
> > > The callout is not yet initialised.
> > > 
> > > Invert the folling lines in ld_sdmmc_attach:
> > > 
> > > +       ldattach(ld);
> > > +
> > > +       callout_init(&sc->sc_task.task_callout, CALLOUT_MPSAFE);
> > > 
> > > I have no clue how that could work for other people.
> > 
> > That did the trick, thanks.
> 
> Well, almost. My laptop locks up if the SD card is inserted at boot.

Same here. With DEBUG and DIAGNOSTIC is panics with an assertion failure for 
"ci->ci_level == IPL_NONE" in x86/x86/cpu.c line 1069

It also panics on shutdown with a card inserted.

If i use dd to dump the card (the one i'm using is an old 32Mb MMC card) it
walks off the end of the card and panics, i fixed that by adding:

        // is everything done in terms of blocks?
        if (bp->b_rawblkno >= sc->sc_sf->csd.capacity)
        {
                // trying to read or write past end of device
                bp->b_error = EIO; /* XXX  */
                bp->b_resid = bp->b_bcount;
                lddone(&sc->sc_ld, bp);
                return;
        }

in ld_sdmmc.c in ld_sdmmc_dobio() before the s = splbio(); line.

(I don't know what the bp->b_resid = bp->b_bcount; line does but that
function does it in the error path).

- -- 
[http://pointless.net/]                                   [0x2ECA0975]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (NetBSD)

iQEVAwUBSNvfIwCB+Qwuygl1AQI9Tgf+L8+sIot/lz2aNWhFSM02OVTBluEq3Ml7
6zgpYYy4opNVwC6OSmJK/YgUBcNxhnlIFPBbAye06b8eNZu70CeBAA7wJFzz+yd3
OTk5M+fvP83qIw5lAPNIjvqunQqu615eYSCAR6E+EX1fzsBDsjZJSj+JkTPzL+rR
GTzxZSXdZk/6tL+QLve/iStYPOsH1brF334/WwPifSjxinyWU/6DWt9CERncw820
VbxH1XxNuHZFcb/CxnYw36YOCOGU1TQnW/30Km6TZwD4YnRGteMhp3PLzQSJDBlm
YhajoCeVG4u1KT/7IS/pOm6g0pFzJnzK0vYcX5V0eU4WAE9NwPN5Dg==
=EGvW
-----END PGP SIGNATURE-----