Current-Users archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Noisy ipmi0 after bootup? (really other kernel noise)
2008/9/5 Paul Goyette <paul%whooppee.com@localhost>:
> I'm not at all familiar with ipmi, but looking at the code, I think there's
> at least one problem here. Shouldn't failure to send or receive the command
> result in an SINVALID result?
>
> Index: ipmi.c
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/x86/x86/ipmi.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 ipmi.c
> --- ipmi.c 17 Apr 2008 05:26:11 -0000 1.18
> +++ ipmi.c 5 Sep 2008 12:59:56 -0000
> @@ -1351,7 +1351,7 @@ ipmi_sensor_status(struct ipmi_softc *sc
> if (ipmi_sendcmd(sc, s1->owner_id, s1->owner_lun,
> SE_NETFN, SE_GET_SENSOR_THRESHOLD, 1, data) ||
> ipmi_recvcmd(sc, sizeof(data), &rxlen, data))
> - return ENVSYS_SVALID;
> + return ENVSYS_SINVALID;
>
Probably that's the right thing.
Home |
Main Index |
Thread Index |
Old Index