Re: CLEANFILES usage in src/sys/lkm/dev/isa/Makefile.inc

[Bernd Ernesti <veego%NetBSD.org@localhost>]

On Sun, Jul 20, 2008 at 09:01:10PM +0200, Bernd Ernesti wrote:
> On Thu, May 01, 2008 at 11:14:36PM +0000, Juan Romero Pardines wrote:
> > 
> > Module Name:        src
> > Committed By:       xtraeme
> > Date:               Thu May  1 23:14:35 UTC 2008
> > 
> > Modified Files:
> >     src/sys/lkm/dev/isa: Makefile.inc
> > 
> > Log Message:
> > The template file should be built in ${.OBJDIR} not in ${.CURDIR},
> > build.sh now works.
> 
> It builds too without build.sh, but a make cleandir doesn't remove the
> files lkm_isa.c files when I use OBJDIRs.
> 
> Currently Makefile.inc use this:
>  CLEANFILES+=    ${.CURDIR}/${TEMPL_FILE:S/.tmpl//} *~ ${KMOD}
> 
> IMHO the ${.CURDIR}/ part is not needed at all.
> 
> I think it should be changed to
>  CLEANFILES+=    ${TEMPL_FILE:S/.tmpl//} ${KMOD}
> 
> Which removed the *~ part too.
> Or is there a reason why *~ files are deleted? IMHO they should
> not be there at all.

Fixed the .CURDIR part in rev. 1.10
I didn't touch the *~ part.

Bernd