Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

ongoing rump udf build failure - and strict-aliasing warnings generally



I've been getting this failure for a couple of weeks now, which is
worrying - clearly others aren't seeing the same thing.  some
combination of compiler flags and gcc's heisen-warnings, I guess.

This is when building udf as a rump.

/home/NetBSD/obj/p4/home/NetBSD/HEAD/src/tooldir.NetBSD-4.99.69-i386/bin/i386--netbsdelf-gcc
 -O0 -g -Wno-pointer-sign -DUDF_READWRITE -DDEBUG -DDIAGNOSTIC -ffreestanding 
-Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
-Wno-sign-compare -Wno-traditional -Wreturn-type -Wswitch -Wshadow -Wcast-qual 
-Wwrite-strings -Wextra -Wno-unused-parameter -std=gnu99  -Werror -march=nocona 
-O2 -pipe -fstack-protector -Wstack-protector --param ssp-buffer-size=1  
-I/home/NetBSD/HEAD/src/sys/rump/include  
-I/home/NetBSD/HEAD/src/sys/rump/fs/lib/libudf -I. -D_KERNEL 
-I/home/NetBSD/HEAD/src/common/include -D_RUMPKERNEL -nostdinc 
-I/home/NetBSD/HEAD/src/sys   -nostdinc -isystem 
/home/NetBSD/obj/p4/home/NetBSD/HEAD/src/destdir.i386/usr/include -c    
/home/NetBSD/HEAD/src/sys/fs/udf/udf_allocation.c -o udf_allocation.o

/home/NetBSD/HEAD/src/sys/fs/udf/udf_allocation.c:1568: warning: dereferencing 
type-punned pointer will break strict-aliasing rules

In the course of investigating this, I was concerned to learn that we
seem to have disabled this warning for the kernel generally.  This
leads to these kinds of problems creeping in undetected, until they
crawl out from under that rock when built separately like this.  

Who wants to go on a crusade to fix the existing cases so we can
remove:

share/mk/bsd.kmod.mk:CFLAGS+=         -fno-strict-aliasing -Wno-pointer-sign
share/mk/bsd.kmodule.mk:CFLAGS+=      -fno-strict-aliasing -Wno-pointer-sign
sys/conf/Makefile.kern.inc:CFLAGS+=   -fno-strict-aliasing

and stop these coming back?  Even using CFLAGS.filename+= for specific
known problem cases would be better as a way to get there.

--
Dan.

Attachment: pgpCncQ8optFM.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index