[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: rump missing cv_has_waiters?
On Thu Jun 05 2008 at 22:29:29 +0100, Andrew Doran wrote:
> > Please don't use #ifdef _RUMPKERNEL in the kernel sources. It's _always_
> > the wrong thing to do (*). I originally added _RUMPKERNEL because
> > I couldn't figure out a way to get the kauth_cred_t type defined
> > properly for non-NetBSD hosts in rump.h. A nicer way is to introduce
> > similar functionality to pthread. <rant>Userspace and kernelspace
> > sychnoronization interfaces should be unified anyway.</rant>
> > But if someone wants to fix the build, I'm not going to jump up and
> > down objecting. It's doubtful I'll get around to looking at the proper
> > fix before next week.
> It'll need something like a pthread_cond_haswaiters_np(), for now I've just
> removed DIAGNOSTIC from the Makefile.
Sounds good, thanks.
> I also just noticed that rump roots itself at NETBSDSRCDIR/sys, so I've
> been building using a mixture of two source trees and scratching my head
> trying to figure out WTF is wrong. ;-)
Heh, reminds me of when I was scratching my head since I forgot to
include bsd.own.mk in some Makefiles and had a /sys symlink ;)
Main Index |
Thread Index |