Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

missing splx() at src/sys/dev/usb/ohci.c:ohci_resume()

To: current-users%netbsd.org@localhost
Subject: missing splx() at src/sys/dev/usb/ohci.c:ohci_resume()
From: "NONAKA Kimihiro" <nonakap%gmail.com@localhost>
Date: Wed, 4 Jun 2008 17:17:28 +0900

Isn't splx() necessary?

--- ohci.c.orig 2008-04-29 11:49:42.000000000 +0900
+++ ohci.c      2008-06-04 15:42:32.000000000 +0900
@@ -1038,6 +1038,7 @@
        usb_delay_ms(&sc->sc_bus, USB_RESUME_RECOVERY);
        sc->sc_control = sc->sc_intre = 0;
        sc->sc_bus.use_polling--;
+       splx(s);

        return true;
 }

Regards,
-- 
NONAKA Kimihiro

Follow-Ups:
- Re: missing splx() at src/sys/dev/usb/ohci.c:ohci_resume()
  - From: Martin Husemann

Prev by Date: Re: long delay during boot
Next by Date: Re: Weird interrupt issues with -current
Previous by Thread: daily CVS update output
Next by Thread: Re: missing splx() at src/sys/dev/usb/ohci.c:ohci_resume()
Indexes:

Home | Main Index | Thread Index | Old Index