Re: aiboost panics my kernel

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Wed, Apr 16, 2008 at 02:04:12PM -0700, Paul Goyette wrote:
> On Wed, 16 Apr 2008, Juan Romero Pardines wrote:
>
>> 2008/4/16, Paul Goyette <paul%whooppee.com@localhost>:
>>
>>> Hmmm, that doesn't look right!  Won't that always evaluate to TRUE?  :)
>>>
>>> Also, do you intend to remove the for (...) loop, or simply change the
>>> if (...) statement?  (Confusing, given the indentation...)
>>
>> Erm right. Just change it to ACPI_TYPE_LOCAL_REFERENCE as Jared
>> pointed out.
>
> Well, that didn't work!  :)
>
> I'm currently remote from the system to verify the console output matches 
> the previous error, but the machine has not successfully rebooted after 
> making the change.

I tried the attached patch, and it didn't change a thing.
 Thomas

Index: aiboost.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/aiboost.c,v
retrieving revision 1.22
diff -u -r1.22 aiboost.c
--- aiboost.c   1 Feb 2008 23:12:30 -0000       1.22
+++ aiboost.c   16 Apr 2008 22:36:31 -0000
@@ -343,8 +343,8 @@
 
        for (i = 1; i < o->Package.Count; i++) {
                elem = &o->Package.Elements[i];
-               if (elem->Type != ACPI_TYPE_ANY) {
-                       DPRINTF(("%s: elem->Type != ACPI_TYPE_ANY\n",
+               if (elem->Type != ACPI_TYPE_LOCAL_REFERENCE) {
+                       DPRINTF(("%s: elem->Type != 
ACPI_TYPE_LOCAL_REFERENCE\n",
                            __func__));
                        goto error;
                }