[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
tolower()/islower() and char
In xentools, we have patches like
- if (tolower(*s) != tolower(*se))
+ if (tolower((unsigned char)*s) != tolower((unsigned char)*se))
(s and se being char*)
This is to fix «array subscript has type 'char' [-Werror=char-subscripts]»
I submitted this to Xen, and a developper asks:
> Isn't this something that wants changing in your ctype.h instead?
> the functions (or macros), as per the C standard, ought to accept
> plain char aiui, and if they use the input as an array subscript,
> it should be their implementation suitably converting type first.
Any comment about this ? I'm not familiar with these details ...
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
NetBSD: 26 ans d'experience feront toujours la difference
Main Index |
Thread Index |